public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Matt Roper <matthew.d.roper-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] Documentation/cgroup-v1: fix outdated programming details
Date: Tue, 2 Jan 2018 16:37:08 -0800	[thread overview]
Message-ID: <20180103003708.GH3668920@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20180103001202.GX5820-b/RNqDZ/lqH1fpGqjiHozbKMmGWinSIL2HeeBUIffwg@public.gmane.org>

Hello, Matt.

On Tue, Jan 02, 2018 at 04:12:02PM -0800, Matt Roper wrote:
> To make sure I'm understanding correctly --- you're suggesting that
> instead of using a cgroup controller to add values (priority, vram,
> etc.) as directly-accessible file nodes under a cgroup's kernfs
> directory that I instead add new driver-specific ioctls (e.g.,
> DRM_IOCTL_SET_CGROUP_PRIORITY) to programmatically update a driver
> internal cgroup=>priority mapping table?  I think that roughly matches
> what I see the bpf code doing with BPF_PROG_ATTACH in the bpf syscall.

Yes, something along that line.

> I was originally hoping for some way that a driver could add entries to
> the cgroup directory since that's easy to configure with something as
> simple as a sysv-init script (and matches how other system policy values
> will be updated).  But I guess we can write a simple userland tool to go
> with our driver that can be called from such a script.
>
> I guess the other alternative would be to try to mirror the cgroup
> hierarchy in a driver-specific sysfs or debugfs tree where we'd add our
> own value files, but that's probably more hassle than it's worth.

It really depends on whether it needs to be full-fledged resource
controller or not.  The reason bpf is that way is because it can't be
delegated and thus fits better when treated as a bpf mechanism which
also matches cgroup membership rather than the other way around.  On
the other hand, rdma is a full controller because it does fit the
resource controller model.

I have no idea what your requirements are, so I can't tell what'd fit
your use case better.  It'd be great if you can ELI5 what you have on
mind.

Thanks.

-- 
tejun

      parent reply	other threads:[~2018-01-03  0:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-29 20:01 [PATCH 1/2] Documentation/cgroup-v1: fix outdated programming details Matt Roper
2017-12-29 20:02 ` [PATCH 2/2] cgroup: Update documentation reference Matt Roper
2018-01-02 15:00   ` Tejun Heo
     [not found] ` <20171229200200.18873-1-matthew.d.roper-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-12-29 20:34   ` [PATCH 1/2] Documentation/cgroup-v1: fix outdated programming details Matt Roper
     [not found]     ` <20171229203449.GS5820-b/RNqDZ/lqH1fpGqjiHozbKMmGWinSIL2HeeBUIffwg@public.gmane.org>
2018-01-02 15:05       ` Tejun Heo
     [not found]         ` <20180102150502.GC3668920-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2018-01-03  0:12           ` Matt Roper
     [not found]             ` <20180103001202.GX5820-b/RNqDZ/lqH1fpGqjiHozbKMmGWinSIL2HeeBUIffwg@public.gmane.org>
2018-01-03  0:37               ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180103003708.GH3668920@devbig577.frc2.facebook.com \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matthew.d.roper-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox