From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dennis Zhou <dennisszhou@gmail.com>
Subject: Re: [PATCH 06/15] blkcg: always associate a bio with a blkg
Date: Thu, 6 Sep 2018 16:41:54 -0400
Message-ID: <20180906204153.GA26048@dennisz-mbp.dhcp.thefacebook.com>
References: <20180831015356.69796-1-dennisszhou@gmail.com>
 <20180831015356.69796-7-dennisszhou@gmail.com>
 <20180831231609.GD1488037@devbig004.ftw2.facebook.com>
Mime-Version: 1.0
Return-path: <linux-kernel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=KkHyODO2LSs2B8yvP42X+QdwGHycGvN193FxePG3aQk=;
        b=t3T5adKYRwRFPQMhEvUeP2yfGV374Fe54ZxfTYTpaTMdl7Y7B5aoD1cAf88u1HCSyf
         bSswgjNuTadYjutV8OEkmsXMgy2h5CI5CfEiur56DUWTQJrPdImzrEr/o4K/O7jdlvrS
         M6LIXbhnpQQZPRDq7W4oR4ssWeqhanK016GmxKJ48SwWX1HkCTqNyhpzgZzjeaMCyn0W
         Lo+mh5nNZgq46s3WXsFGc5KGvzBxMMgVYfF2Wx5u6d3d0p0bU4hH98gtv9SvWb4Tep26
         0b9xAxbXCL7FuYo6SvIMuss9m+8PR6B8fyMeHOOsOh/rAYFcIa3HuN1oglz578Bq7FQF
         ieDA==
Content-Disposition: inline
In-Reply-To: <20180831231609.GD1488037@devbig004.ftw2.facebook.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <cgroups.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, Johannes Weiner <hannes@cmpxchg.org>, Josef Bacik <josef@toxicpanda.com>, kernel-team@fb.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org

On Fri, Aug 31, 2018 at 04:16:09PM -0700, Tejun Heo wrote:
> Hello,
> 
> On Thu, Aug 30, 2018 at 09:53:47PM -0400, Dennis Zhou wrote:
> > From: "Dennis Zhou (Facebook)" <dennisszhou@gmail.com>
> > 
> > Previously, blkg's were only assigned as needed by blk-iolatency and
> > blk-throttle. bio->css was also always being associated while blkg was
> > being looked up and then thrown away in blkcg_bio_issue_check.
> > 
> > This patch beings the cleanup of bio->css and bio->bi_blkg by always
>              ^
> 	     begins
> 

Thanks!

> > +int bio_associate_create_blkg(struct request_queue *q, struct bio *bio)
> > +{
> > +	struct blkcg *blkcg;
> > +	struct blkcg_gq *blkg;
> > +	int ret = 0;
> > +
> > +	/* someone has already associated this bio with a blkg */
> > +	if (bio->bi_blkg)
> > +		return ret;
> > +
> > +	rcu_read_lock();
> > +
> > +	bio_associate_blkcg(bio, NULL);
> > +	blkcg = bio_blkcg(bio);
> > +
> > +	if (!blkcg->css.parent) {
> > +		ret = bio_associate_blkg(bio, q->root_blkg);
> > +		goto assoc_out;
> > +	}
> > +
> > +	blkg = blkg_lookup_create(blkcg, q);
> > +	if (IS_ERR(blkg))
> > +		blkg = q->root_blkg;
> > +
> > +	ret = bio_associate_blkg(bio, blkg);
> > +assoc_out:
> 
> Maybe if/else instead of goto?
> 

Yeah, no need for goto.

Thanks,
Dennis