From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Gushchin Subject: [PATCH v4 5/7] kselftests: cgroup: don't fail on cg_kill_all() error in cg_destroy() Date: Fri, 30 Nov 2018 15:47:43 -0800 Message-ID: <20181130234745.6756-6-guro@fb.com> References: <20181130234745.6756-1-guro@fb.com> Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oiVWgL/WHUTd0gentorRc6DDTrlDET1vasHz44Fkvas=; b=bkac+1geXCQMO7SBGOHvZYHy+O1blewP8Fl9p5hxw+eIZxmX5Dmdkxefu53YmAODGv ArCDssqsorbtsVVUA7FVvlNYYZ987LCMhIpv0DqUB/jzpfDXtJDghqSa/KXydxtN06dS opbTdxUVgO9nQXx5Eng4S0A6atZmaSPJzIxoMEpOujx8zDxDVVJmYlKu1Itc24gGv4Ed EMVieW+0ME1m1gy2ynCnWl2o6WwMQK7BxuLPw4HDH1uBgR55ENZ3sGQXGuP3kJDi+Qg8 Oj1Ojjz+VqF+3ROVtu2Eom7E07dmDW2ql1xzzx3iOsjpem0B+TwK2CzlqqeYzttebd2a MbEA== In-Reply-To: <20181130234745.6756-1-guro@fb.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo , Oleg Nesterov Cc: Dan Carpenter , Mike Rapoport , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Roman Gushchin , Shuah Khan , linux-kselftest@vger.kernel.org If the cgroup destruction races with an exit() of a belonging process(es), cg_kill_all() may fail. It's not a good reason to make cg_destroy() fail and leave the cgroup in place, potentially causing next test runs to fail. Signed-off-by: Roman Gushchin Cc: Shuah Khan Cc: Tejun Heo Cc: kernel-team@fb.com Cc: linux-kselftest@vger.kernel.org --- tools/testing/selftests/cgroup/cgroup_util.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c index 14c9fe284806..eba06f94433b 100644 --- a/tools/testing/selftests/cgroup/cgroup_util.c +++ b/tools/testing/selftests/cgroup/cgroup_util.c @@ -227,9 +227,7 @@ int cg_destroy(const char *cgroup) retry: ret = rmdir(cgroup); if (ret && errno == EBUSY) { - ret = cg_killall(cgroup); - if (ret) - return ret; + cg_killall(cgroup); usleep(100); goto retry; } -- 2.17.2