From: Juri Lelli <juri.lelli@redhat.com>
To: peterz@infradead.org, mingo@redhat.com, rostedt@goodmis.org,
tj@kernel.org
Cc: linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it,
claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it,
bristot@redhat.com, mathieu.poirier@linaro.org,
lizefan@huawei.com, cgroups@vger.kernel.org,
Juri Lelli <juri.lelli@redhat.com>
Subject: [PATCH v7 0/7] sched/deadline: fix cpusets bandwidth accounting
Date: Wed, 3 Apr 2019 10:46:43 +0200 [thread overview]
Message-ID: <20190403084650.4414-1-juri.lelli@redhat.com> (raw)
Hi,
v7 of a series of patches, originally authored by Mathieu, with the intent
of fixing a long standing issue of SCHED_DEADLINE bandwidth accounting.
As originally reported by Steve [1], when hotplug and/or (certain)
cpuset reconfiguration operations take place, DEADLINE bandwidth
accounting information is lost since root domains are destroyed and
recreated.
Mathieu's approach is based on restoring bandwidth accounting info on
the newly created root domains by iterating through the (DEADLINE) tasks
belonging to the configured cpuset(s).
Apart from the usual rebase on top of cgroup/for-next, changes worth of
notice are:
- commented about potential problems w.r.t. userspace operations that
grabs callback_lock (03/07 - peterz)
- take cpuset_read_only_lock() before rq an pi locks, as to not
introduce a dependency between the former and the latters; on !CONFIG_
CPUSET cpuset_read_only(un)lock() (dis/en)ables irqs and preemption
(04/07 - peterz)
- make dl_add_task_root_domain() use !_irqsave (un)lock functions
- also use __dl_add() to update root domain total_bw
- 06/07 new patch; seq_show operations can be guarded by cpuset_mutex
(peterz)
- 07/07 new patch; deals with offline migrations (noticed the problem
while testing)
Set also available at
https://github.com/jlelli/linux.git fixes/deadline/root-domain-accounting-v7
Thanks,
- Juri
[1] https://lkml.org/lkml/2016/2/3/966
Juri Lelli (5):
cgroup/cpuset: make callback_lock raw
sched/core: Prevent race condition between cpuset and
__sched_setscheduler()
cpuset: Rebuild root domain deadline accounting information
cgroup/cpuset: Use cpuset_mutex to protect seq_show operations
sched/deadline: Fix bandwidth accounting at all levels after offline
migration
Mathieu Poirier (2):
sched/topology: Adding function partition_sched_domains_locked()
sched/core: Streamlining calls to task_rq_unlock()
include/linux/cgroup.h | 1 +
include/linux/cpuset.h | 14 +++
include/linux/sched.h | 5 +
include/linux/sched/deadline.h | 8 ++
include/linux/sched/topology.h | 10 ++
kernel/cgroup/cgroup.c | 2 +-
kernel/cgroup/cpuset.c | 161 +++++++++++++++++++++++++--------
kernel/sched/core.c | 49 +++++++---
kernel/sched/deadline.c | 63 +++++++++++++
kernel/sched/sched.h | 3 -
kernel/sched/topology.c | 30 +++++-
11 files changed, 286 insertions(+), 60 deletions(-)
--
2.17.2
next reply other threads:[~2019-04-03 8:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 8:46 Juri Lelli [this message]
2019-04-03 8:46 ` [PATCH v7 1/7] sched/topology: Adding function partition_sched_domains_locked() Juri Lelli
2019-04-05 12:04 ` Peter Zijlstra
2019-04-05 12:52 ` Juri Lelli
2019-04-03 8:46 ` [PATCH v7 2/7] sched/core: Streamlining calls to task_rq_unlock() Juri Lelli
2019-04-03 8:46 ` [PATCH v7 3/7] cgroup/cpuset: make callback_lock raw Juri Lelli
2019-04-03 8:46 ` [PATCH v7 4/7] sched/core: Prevent race condition between cpuset and __sched_setscheduler() Juri Lelli
2019-04-05 12:36 ` Peter Zijlstra
2019-04-05 12:53 ` Juri Lelli
2019-04-03 8:46 ` [PATCH v7 5/7] cpuset: Rebuild root domain deadline accounting information Juri Lelli
2019-04-03 8:46 ` [PATCH v7 6/7] cgroup/cpuset: Use cpuset_mutex to protect seq_show operations Juri Lelli
2019-04-03 8:46 ` [PATCH v7 7/7] sched/deadline: Fix bandwidth accounting at all levels after offline migration Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403084650.4414-1-juri.lelli@redhat.com \
--to=juri.lelli@redhat.com \
--cc=bristot@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=claudio@evidence.eu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=luca.abeni@santannapisa.it \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=tommaso.cucinotta@santannapisa.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).