From: Juri Lelli <juri.lelli@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@redhat.com, rostedt@goodmis.org, tj@kernel.org,
linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it,
claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it,
bristot@redhat.com, mathieu.poirier@linaro.org,
lizefan@huawei.com, cgroups@vger.kernel.org
Subject: Re: [PATCH v7 1/7] sched/topology: Adding function partition_sched_domains_locked()
Date: Fri, 5 Apr 2019 14:52:45 +0200 [thread overview]
Message-ID: <20190405125245.GB5453@localhost.localdomain> (raw)
In-Reply-To: <20190405120434.GS12232@hirez.programming.kicks-ass.net>
Hi,
On 05/04/19 14:04, Peter Zijlstra wrote:
> On Wed, Apr 03, 2019 at 10:46:44AM +0200, Juri Lelli wrote:
> > +/*
> > + * Call with hotplug lock held
>
> Is that spelled like:
>
> lockdep_assert_cpus_held();
>
> ?
Indeed, but I had that in previous versions and we removed that in v5
because it can lead to false positives [1,2]. IIRC, problem has to do
with hotplug and the fact that rebuilding from hotplug runs the
callbacks on the newly onlined CPU, not the task that acquired the lock.
Best,
- Juri
1 - https://lore.kernel.org/lkml/20180903142801.20046-1-juri.lelli@redhat.com/
2 - https://lore.kernel.org/lkml/20180613121711.5018-2-juri.lelli@redhat.com/
next prev parent reply other threads:[~2019-04-05 12:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 8:46 [PATCH v7 0/7] sched/deadline: fix cpusets bandwidth accounting Juri Lelli
2019-04-03 8:46 ` [PATCH v7 1/7] sched/topology: Adding function partition_sched_domains_locked() Juri Lelli
2019-04-05 12:04 ` Peter Zijlstra
2019-04-05 12:52 ` Juri Lelli [this message]
2019-04-03 8:46 ` [PATCH v7 2/7] sched/core: Streamlining calls to task_rq_unlock() Juri Lelli
2019-04-03 8:46 ` [PATCH v7 3/7] cgroup/cpuset: make callback_lock raw Juri Lelli
2019-04-03 8:46 ` [PATCH v7 4/7] sched/core: Prevent race condition between cpuset and __sched_setscheduler() Juri Lelli
2019-04-05 12:36 ` Peter Zijlstra
2019-04-05 12:53 ` Juri Lelli
2019-04-03 8:46 ` [PATCH v7 5/7] cpuset: Rebuild root domain deadline accounting information Juri Lelli
2019-04-03 8:46 ` [PATCH v7 6/7] cgroup/cpuset: Use cpuset_mutex to protect seq_show operations Juri Lelli
2019-04-03 8:46 ` [PATCH v7 7/7] sched/deadline: Fix bandwidth accounting at all levels after offline migration Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405125245.GB5453@localhost.localdomain \
--to=juri.lelli@redhat.com \
--cc=bristot@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=claudio@evidence.eu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=luca.abeni@santannapisa.it \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=tommaso.cucinotta@santannapisa.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).