From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: [PATCH v10 4/9] cgroup: cgroup v2 freezer Date: Fri, 26 Apr 2019 19:30:36 +0200 Message-ID: <20190426173035.GA24755@redhat.com> References: <20190405174708.1010-1-guro@fb.com> <20190405174708.1010-5-guro@fb.com> <20190424160237.GH16167@redhat.com> <20190424221034.GB22896@tower.DHCP.thefacebook.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20190424221034.GB22896@tower.DHCP.thefacebook.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Roman Gushchin Cc: Roman Gushchin , Tejun Heo , Kernel Team , "cgroups@vger.kernel.org" , "linux-kernel@vger.kernel.org" On 04/24, Roman Gushchin wrote: > > of the patchset. In the current iteration I'd replace it with: > > WARN_ON_ONCE(cgroup_task_frozen(tsk)); > > just to make sure we're not leaking the frozen bit. > Do you agree? Yes sure, Oleg.