From: Juri Lelli <juri.lelli@redhat.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: peterz@infradead.org, mingo@redhat.com, rostedt@goodmis.org,
lizefan@huawei.com, tj@kernel.org, bristot@redhat.com,
luca.abeni@santannapisa.it, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/core: Fix cpu controller for !RT_GROUP_SCHED
Date: Wed, 19 Jun 2019 14:34:05 +0200 [thread overview]
Message-ID: <20190619123405.GN26005@localhost.localdomain> (raw)
In-Reply-To: <20190619092904.GB28937@blackbody.suse.cz>
Hi,
On 19/06/19 11:29, Michal Koutný wrote:
> On Wed, Jun 05, 2019 at 04:20:03PM +0200, Michal Koutný <mkoutny@suse.com> wrote:
> > I considered relaxing the check to non-root cgroups only, however, as
> > your example shows, it doesn't prevent reaching the avoided state by
> > other paths. I'm not that familiar with RT sched to tell whether
> > RT-priority tasks in different task_groups break any assumptions.
> So I had another look and the check is bogus.
>
> The RT sched with !CONFIG_RT_GROUP_SCHED works only with the struct
> rt_rq embedded in the generic struct rq -- regardless of the task's
> membership in the cpu controller hierarchy.
Yep.
> Perhaps, the commit message may mention this also prevents enabling cpu
> controller on unified hierarchy (if there are any (kernel) RT tasks to
> migrate).
Sure. Can add such a comment.
> Reviewed-by: Michal Koutný <mkoutny@suse.com>
Thanks!
Peter?
Best,
Juri
prev parent reply other threads:[~2019-06-19 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 11:49 [PATCH] sched/core: Fix cpu controller for !RT_GROUP_SCHED Juri Lelli
2019-06-05 13:34 ` Tejun Heo
2019-06-05 14:20 ` Michal Koutný
2019-06-19 9:29 ` Michal Koutný
2019-06-19 12:34 ` Juri Lelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619123405.GN26005@localhost.localdomain \
--to=juri.lelli@redhat.com \
--cc=bristot@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=luca.abeni@santannapisa.it \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox