From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH] mm, slab: Extend slab/shrink to shrink all the memcg caches Date: Wed, 3 Jul 2019 08:56:28 +0200 Message-ID: <20190703065628.GK978@dhcp22.suse.cz> References: <20190702183730.14461-1-longman@redhat.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20190702183730.14461-1-longman@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Waiman Long Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Alexander Viro , Jonathan Corbet , Luis Chamberlain , Kees Cook , Johannes Weiner , Vladimir Davydov , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Roman Gushchin , Shakeel Butt , Andrea Arcangeli On Tue 02-07-19 14:37:30, Waiman Long wrote: > Currently, a value of '1" is written to /sys/kernel/slab//shrink > file to shrink the slab by flushing all the per-cpu slabs and free > slabs in partial lists. This applies only to the root caches, though. > > Extends this capability by shrinking all the child memcg caches and > the root cache when a value of '2' is written to the shrink sysfs file. Why do we need a new value for this functionality? I would tend to think that skipping memcg caches is a bug/incomplete implementation. Or is it a deliberate decision to cover root caches only? -- Michal Hocko SUSE Labs