From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juri Lelli Subject: Re: [PATCH v8 6/8] cgroup/cpuset: Change cpuset_rwsem and hotplug lock order Date: Thu, 4 Jul 2019 10:49:24 +0200 Message-ID: <20190704084924.GC9099@localhost.localdomain> References: <20190628080618.522-1-juri.lelli@redhat.com> <20190628080618.522-7-juri.lelli@redhat.com> <20190628130308.GU3419@hirez.programming.kicks-ass.net> <20190701065233.GA26005@localhost.localdomain> <20190701082731.GP3402@hirez.programming.kicks-ass.net> <20190701145107.GY657710@devbig004.ftw2.facebook.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20190701145107.GY657710@devbig004.ftw2.facebook.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: Peter Zijlstra , mingo@redhat.com, rostedt@goodmis.org, linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it, claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it, bristot@redhat.com, mathieu.poirier@linaro.org, lizefan@huawei.com, cgroups@vger.kernel.org, Prateek Sood Hi, On 01/07/19 07:51, Tejun Heo wrote: > Hello, > > On Mon, Jul 01, 2019 at 10:27:31AM +0200, Peter Zijlstra wrote: > > IIRC TJ figured it wasn't strictly required to fix the lock invertion at > > that time and they sorted it differently. If I (re)read the thread > > correctly the other day, he didn't have fundamental objections against > > it, but wanted the simpler fix. > > Yeah I've got no objections to the change itself, it just wasn't > needed at the time. We've had multiple issues there tho, so please > keep an eye open after the changes get merged. Should I take this as an indication that you had a look at the set and (apart from Peter's comments) you are OK with them? If that's the case I will send a v9 out soon. Otherwise I'd kindly ask you to please have a look. Thanks! Juri