From: Tejun Heo <tj@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
akpm@linux-foundation.org, arnd@arndb.de, christian@brauner.io,
deepa.kernel@gmail.com, ebiederm@xmission.com, elver@google.com,
guro@fb.com, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com, cgroups@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH cgroup/for-5.5] cgroup: remove cgroup_enable_task_cg_lists() optimization
Date: Fri, 25 Oct 2019 05:56:06 -0700 [thread overview]
Message-ID: <20191025125606.GI3622521@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <20191024190351.GD3622521@devbig004.ftw2.facebook.com>
On Thu, Oct 24, 2019 at 12:03:51PM -0700, Tejun Heo wrote:
> cgroup_enable_task_cg_lists() is used to lazyily initialize task
> cgroup associations on the first use to reduce fork / exit overheads
> on systems which don't use cgroup. Unfortunately, locking around it
> has never been actually correct and its value is dubious given how the
> vast majority of systems use cgroup right away from boot.
>
> This patch removes the optimization. For now, replace the cg_list
> based branches with WARN_ON_ONCE()'s to be on the safe side. We can
> simplify the logic further in the future.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Oleg Nesterov <oleg@redhat.com>
Applying to cgroup/for-5.5.
Thanks.
--
tejun
next prev parent reply other threads:[~2019-10-25 12:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0000000000003b1e8005956939f1@google.com>
[not found] ` <20191021142111.GB1339@redhat.com>
2019-10-24 19:03 ` [PATCH cgroup/for-5.5] cgroup: remove cgroup_enable_task_cg_lists() optimization Tejun Heo
2019-10-25 12:56 ` Tejun Heo [this message]
2019-10-25 13:33 ` Christian Brauner
2019-10-25 14:13 ` Oleg Nesterov
2019-10-25 14:32 ` Christian Brauner
2019-10-25 15:52 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025125606.GI3622521@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=cgroups@vger.kernel.org \
--cc=christian@brauner.io \
--cc=deepa.kernel@gmail.com \
--cc=ebiederm@xmission.com \
--cc=elver@google.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=oleg@redhat.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).