From mboxrd@z Thu Jan  1 00:00:00 1970
From: Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v4 9/9] mm/lru: revise the comments of lru_lock
Date: Tue, 19 Nov 2019 11:19:58 -0500
Message-ID: <20191119161958.GE382712@cmpxchg.org>
References: <1574166203-151975-1-git-send-email-alex.shi@linux.alibaba.com>
 <1574166203-151975-10-git-send-email-alex.shi@linux.alibaba.com>
Mime-Version: 1.0
Return-path: <linux-kernel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=cmpxchg-org.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=P9Nm0dmtDONqzZOiG8f0kC+bAXI7b+Ydc24QnuYX/wc=;
        b=z9ODofZLwVJ5kMknpHKRESiJDZBNi3Pyza7Lc9GUeJNHofrQ86wibU3eFnsO2CVIu+
         IfAgM62vq+764hz0qZ7RurgWgkiidhrvNyqW6ve6XTcrt1pa0T+IBaQFh6GvVNqcIXBF
         Ufy2rTPODX34yXNizSAi3WtQarGWeLPCoeXXJKP8I0Cb0CRRWpEy9NOqkoaP9VmwY9h1
         cD8j9AgPTXAvnN73paddQAX1/NUY7TjJhO4MrEwcGMLbJNfqlaFEN76hxgxI1sUPxUoF
         rpTdJBr0sBkYiM5s7RkzXWL86X/Ms+STXj4E4DantEgdps6LghwvRYO6bCdspBkQ3lot
         zPnQ==
Content-Disposition: inline
In-Reply-To: <1574166203-151975-10-git-send-email-alex.shi@linux.alibaba.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <cgroups.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Alex Shi <alex.shi@linux.alibaba.com>
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, shakeelb@google.com, Jason Gunthorpe <jgg@ziepe.ca>, Dan Williams <dan.j.williams@intel.com>, Vlastimil Babka <vbabka@suse.cz>, Ira Weiny <ira.weiny@intel.com>, Jesper Dangaard Brouer <brouer@redhat.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Jann Horn <jannh@google.com>, Logan Gunthorpe <logang@deltatee.com>, Souptick Joarder <jrdr.linux@gmail.com>, Ralph Campbell <rcampbell@nvidia.com>, "Tobin C. Harding" <tobin@kernel.org>, Michal Hocko <mhocko@suse.com>, Oscar Salvador <osalvado>

On Tue, Nov 19, 2019 at 08:23:23PM +0800, Alex Shi wrote:
> Since we changed the pgdat->lru_lock to lruvec->lru_lock, it's time to
> fix the incorrect comments in code. Also fixed some zone->lru_lock comment
> error from ancient time. etc.
> 
> Originally-from: Hugh Dickins <hughd@google.com>

You can resubmit a patch written by somebody else, but you need to
preserve authorship such that git can attribute it properly:

	From: Hugh Dickins <hughd@google.com>

in the patch header, as well as

	Signed-off-by: Hugh Dickins <hughd@google.com>

in the changelog tags. It should look something like this:

---
From: Hugh Dickins <hughd@google.com>
Subject: [PATCH] mm/memcg: update lru_lock Doc and comments

Update scattered references from "zone_lru_lock" to "lruvec->lru_lock"
(in low-level descriptions) or "lruvec lock" (where that reads better).

In the course of doing so, update lock ordering comments in mm/rmap.c
and mm/filemap.c and Documentation/cgroups/memory.txt - slightly, with
no attempt to be complete (swap_lock, in particular, left out-of-date).
Remove allusions to set_page_dirty under page_remove_rmap: gone in v3.9.

memcg_test.txt looks quite out-of-date: just give LRU a short paragraph.
Replaced zone by node throughout unevictable-lru.txt (except for stats).
Leave Documentation/locking/lockstat.txt untouched this time: it doesn't
matter if that still refers to zone->lru_lock, along with other history.

I struggled to understand the comment above move_pages_to_lru() (surely
it never calls page_referenced()), and eventually realized that most of
it had got separated from shrink_active_list(): move that comment back.

Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
---