From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Benjamin Berg <benjamin-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [BUG] NULL pointer de-ref when setting io.cost.qos on LUKS devices
Date: Tue, 3 Mar 2020 09:19:02 -0500 [thread overview]
Message-ID: <20200303141902.GB189690@mtj.thefacebook.com> (raw)
In-Reply-To: <1dbdcbb0c8db70a08aac467311a80abcf7779575.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Hello,
On Tue, Mar 03, 2020 at 03:13:10PM +0100, Benjamin Berg wrote:
> so, I tried to set io.latency for some cgroups for the root device,
> which is ext4 inside LVM inside LUKS.
It's pointless on compound devices. I think the right thing to do here
is disallowing to enable it on those devices.
Thanks.
--
tejun
next prev parent reply other threads:[~2020-03-03 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 14:13 [BUG] NULL pointer de-ref when setting io.cost.qos on LUKS devices Benjamin Berg
[not found] ` <1dbdcbb0c8db70a08aac467311a80abcf7779575.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2020-03-03 14:19 ` Tejun Heo [this message]
[not found] ` <20200303141902.GB189690-146+VewaZzwNjtGbbfXrCEEOCMrvLtNR@public.gmane.org>
2020-03-03 14:40 ` Benjamin Berg
[not found] ` <24bd31cdaa3ea945908bc11cea05d6aae6929240.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2020-03-04 16:42 ` Tejun Heo
[not found] ` <20200304164205.GH189690-146+VewaZzwNjtGbbfXrCEEOCMrvLtNR@public.gmane.org>
2020-03-05 10:31 ` Benjamin Berg
[not found] ` <71515f7a143937ab9ab11625485659bb7288f024.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2020-03-05 15:20 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303141902.GB189690@mtj.thefacebook.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=benjamin-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).