From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Qian Cai <cai-J5quhbR+WMc@public.gmane.org>
Cc: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cgroup: fix psi_show() crash on 32bit ino archs
Date: Wed, 4 Mar 2020 11:16:17 -0500 [thread overview]
Message-ID: <20200304161617.GD189690@mtj.thefacebook.com> (raw)
In-Reply-To: <20200224030007.3990-1-cai-J5quhbR+WMc@public.gmane.org>
On Sun, Feb 23, 2020 at 10:00:07PM -0500, Qian Cai wrote:
> Similar to the commit d7495343228f ("cgroup: fix incorrect
> WARN_ON_ONCE() in cgroup_setup_root()"), cgroup_id(root_cgrp) does not
> equal to 1 on 32bit ino archs which triggers all sorts of issues with
> psi_show() on s390x. For example,
>
> BUG: KASAN: slab-out-of-bounds in collect_percpu_times+0x2d0/
> Read of size 4 at addr 000000001e0ce000 by task read_all/3667
> collect_percpu_times+0x2d0/0x798
> psi_show+0x7c/0x2a8
> seq_read+0x2ac/0x830
> vfs_read+0x92/0x150
> ksys_read+0xe2/0x188
> system_call+0xd8/0x2b4
>
> Fix it by using cgroup_ino().
>
> Fixes: 743210386c03 ("cgroup: use cgrp->kn->id as the cgroup ID")
> Signed-off-by: Qian Cai <cai-J5quhbR+WMc@public.gmane.org>
Applied to cgroup/for-5.6-fixes.
Thanks.
--
tejun
prev parent reply other threads:[~2020-03-04 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 3:00 [PATCH] cgroup: fix psi_show() crash on 32bit ino archs Qian Cai
[not found] ` <20200224030007.3990-1-cai-J5quhbR+WMc@public.gmane.org>
2020-02-24 16:29 ` Johannes Weiner
[not found] ` <20200224162906.GB1674-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2020-03-04 13:36 ` Qian Cai
2020-03-04 16:16 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304161617.GD189690@mtj.thefacebook.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cai-J5quhbR+WMc@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).