From: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Vincenzo Frascino <vincenzo.frascino-5wv7dgnIgG8@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Vladimir Davydov
<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCH] mm: Make mem_cgroup_id_get_many dependent on MMU and MEMCG_SWAP
Date: Thu, 5 Mar 2020 15:18:45 +0100 [thread overview]
Message-ID: <20200305141845.GZ16139@dhcp22.suse.cz> (raw)
In-Reply-To: <acf13158-40a3-4027-f36a-25d24efe3242-5wv7dgnIgG8@public.gmane.org>
On Thu 05-03-20 10:46:21, Vincenzo Frascino wrote:
[...]
> I am aware of this. I was just exploring if there was a possibility of
> addressing the warning, since if we leave all the warnings in scenarios like
> randconfig can cause confusion in between real and non real issues.
I would very much like to address _real_ warnings. This one is just
bugus. I do not see a fix that would be sensible. Wrapping the helper
by ifdefs is just going to make the resulting code worse because there
is nothing really specific to swap there. Marking it __maybe_unused will
just paper over the report and allow the function to bitrot when it is
not used anymore.
So for now I would just live with the warning unless it is really
causing any real problems.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-03-05 14:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 14:23 [PATCH] mm: Make mem_cgroup_id_get_many dependent on MMU and MEMCG_SWAP Vincenzo Frascino
[not found] ` <20200304142348.48167-1-vincenzo.frascino-5wv7dgnIgG8@public.gmane.org>
2020-03-04 16:53 ` Michal Hocko
[not found] ` <20200304165336.GO16139-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-03-05 9:49 ` Vincenzo Frascino
[not found] ` <8c489836-b824-184e-7cfe-25e55ab73000-5wv7dgnIgG8@public.gmane.org>
2020-03-05 10:00 ` Michal Hocko
2020-03-05 10:46 ` Vincenzo Frascino
[not found] ` <acf13158-40a3-4027-f36a-25d24efe3242-5wv7dgnIgG8@public.gmane.org>
2020-03-05 14:18 ` Michal Hocko [this message]
2020-03-05 16:09 ` Johannes Weiner
2020-03-05 16:21 ` Vincenzo Frascino
[not found] ` <20200305160929.GA1166-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2020-03-05 18:34 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305141845.GZ16139@dhcp22.suse.cz \
--to=mhocko-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=vincenzo.frascino-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox