From: Sergey Senozhatsky <sergey.senozhatsky.work-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: Sergey Senozhatsky
<sergey.senozhatsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Vladimir Davydov
<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Minchan Kim <minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Nitin Gupta <ngupta-KNmc09w0p+Ednm+yROfE0A@public.gmane.org>,
Sergey Senozhatsky
<sergey.senozhatsky.work-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mm: Use fallthrough;
Date: Mon, 9 Mar 2020 15:20:46 +0900 [thread overview]
Message-ID: <20200309062046.GA46830@google.com> (raw)
In-Reply-To: <84f3c9891d4e89909d5537f34ea9d75de339c415.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
On (20/03/08 21:51), Joe Perches wrote:
> On Mon, 2020-03-09 at 13:15 +0900, Sergey Senozhatsky wrote:
> > On (20/03/07 19:54), Joe Perches wrote:
> > > On Sun, 2020-03-08 at 12:18 +0900, Sergey Senozhatsky wrote:
> > > > On (20/03/06 23:58), Joe Perches wrote:
> > > > [..]
[..]
> > > Consecutive case labels do not need an interleaving fallthrough;
> > >
> > > ie: ditto
> >
> > I see. Shall this be mentioned in the commit message, maybe?
>
> <shrug, maybe> I've no real opinion about that necessity.
>
> fallthrough commments are relatively rarely used as a
> separating element between case labels.
>
> It's by far most common to just have consecutive case labels
> without any other content.
>
> It's somewhere between 500:1 to 1000:1 in the kernel.
I thought that those labels were used by some static code analysis
tools, so that the removal of some labels raised questions. But I
don't think I have opinions otherwise.
-ss
next prev parent reply other threads:[~2020-03-09 6:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 7:58 [PATCH] mm: Use fallthrough; Joe Perches
2020-03-07 18:53 ` Gustavo A. R. Silva
2020-03-08 3:16 ` Sergey Senozhatsky
2020-03-08 3:19 ` Joe Perches
[not found] ` <f62fea5d10eb0ccfc05d87c242a620c261219b66.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2020-03-08 3:18 ` Sergey Senozhatsky
[not found] ` <20200308031825.GB1125-NsMb8Yw0+OOoSBNdbAt9fHzaFgp7qdfK@public.gmane.org>
2020-03-08 3:54 ` Joe Perches
[not found] ` <5f297e8995b22c9ccf06d4d0a04f7d9a37d3cd77.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2020-03-09 4:15 ` Sergey Senozhatsky
2020-03-09 4:51 ` Joe Perches
[not found] ` <84f3c9891d4e89909d5537f34ea9d75de339c415.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2020-03-09 6:20 ` Sergey Senozhatsky [this message]
[not found] ` <20200309062046.GA46830-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2020-03-09 6:48 ` Sergey Senozhatsky
[not found] ` <20200309064806.GB46830-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2020-03-10 11:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309062046.GA46830@google.com \
--to=sergey.senozhatsky.work-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=ngupta-KNmc09w0p+Ednm+yROfE0A@public.gmane.org \
--cc=sergey.senozhatsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).