From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonsoo Kim Subject: Re: [PATCH 04/18] mm: memcontrol: move out cgroup swaprate throttling Date: Wed, 22 Apr 2020 15:37:33 +0900 Message-ID: <20200422063732.GD6780@js1304-desktop> References: <20200420221126.341272-1-hannes@cmpxchg.org> <20200420221126.341272-5-hannes@cmpxchg.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=M3V1L8dUG+LHRmYCPUTMgmjn7UaZHh+VkReKQj/vaHo=; b=VLLZvjTyPjUgrOmfVUzEK98z+a3DuIJzk8YklsxG4duu/ZaQG/OxRt8VGQQoJk5rSq w7PDHAUR5t3p6G6E5k1yyL2g/BJnmWDAzsogEl/KU5MclGkgNEPL4u+ymQ9CzV86Qwsy 0DVS6CS9PA+EgKfrysJ1Pol0cTsJA5+L+3fv7IzvAL6fh+PoJ5JNVu+S5fnmoOHeQWDX TAZTS4f/IqI97thaP3pnigLg89b/Gvu1vz/7gT1qkKSgpX1SMizwilKhgqrKOYye0583 aM9l8fc9I5Wdv0p0yXEAD0AxRoj9ohgIbIzLiNGTYouJqv4OA1f8sX7e9qzwcHgN+PWS 17bA== Content-Disposition: inline In-Reply-To: <20200420221126.341272-5-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Johannes Weiner Cc: Alex Shi , Shakeel Butt , Hugh Dickins , Michal Hocko , "Kirill A. Shutemov" , Roman Gushchin , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org On Mon, Apr 20, 2020 at 06:11:12PM -0400, Johannes Weiner wrote: > The cgroup swaprate throttling is about matching new anon allocations > to the rate of available IO when that is being throttled. It's the io > controller hooking into the VM, rather than a memory controller thing. > > Rename mem_cgroup_throttle_swaprate() to cgroup_throttle_swaprate(), > and drop the @memcg argument which is only used to check whether the > preceding page charge has succeeded and the fault is proceeding. > > We could decouple the call from mem_cgroup_try_charge() here as well, > but that would cause unnecessary churn: the following patches convert > all callsites to a new charge API and we'll decouple as we go along. > > Signed-off-by: Johannes Weiner Reviewed-by: Joonsoo Kim