Re: [PATCH v16 20/22] mm/vmscan: use relock for move_pages_to_lru

Alex Shi
2020-07-18T14:15:25Z

在 2020/7/18 上午5:44, Alexander Duyck 写道:
>> if (unlikely(PageCompound(page))) {
>> spin_unlock_irq(&lruvec->lru_lock);
>> + lruvec = NULL;
>> destroy_compound_page(page);
>> - spin_lock_irq(&lruvec->lru_lock);
>> } else
>> list_add(&page->lru, &pages_to_free);
>>
> It seems like this should just be rolled into patch 19. Otherwise if
> you are wanting to consider it as a "further optimization" type patch
> you might pull some of the optimizations you were pushing in patch 18
> into this patch as well and just call it out as adding relocks where
> there previously were none.

This patch is picked from Hugh Dickin's version in my review. It could be
fine to have a extra patch which no harm for anyone. :)

Thanks
Alex