Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged

Stephen Rothwell
2020-08-24T23:00:54Z

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

Hi Michal,

On Mon, 24 Aug 2020 17:10:45 +0200 Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org> wrote:
>
> On Mon 24-08-20 10:52:02, Qian Cai wrote:
> > On Thu, Aug 20, 2020 at 10:58:50AM -0400, Qian Cai wrote:
> > > On Tue, Aug 11, 2020 at 07:10:27PM +0800, Alex Shi wrote:
> > > > Since readahead page is charged on memcg too, in theory we don't have to
> > > > check this exception now. Before safely remove them all, add a warning
> > > > for the unexpected !memcg.
> > > >
> > > > Signed-off-by: Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
> > > > Acked-by: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
> > >
> > > This will trigger,
> >
> > Andrew, Stephen, can you drop this series for now? I did manage to trigger this
> > warning on all arches, powerpc, x86 and arm64 (below).
>
> Yes, I do agree. See http://lkml.kernel.org/r/20200824151013.GB3415@dhcp22.suse.cz

OK, I have removed the following from linux-next for today:

c443db77c9f3 ("mm/thp: narrow lru locking")
18bafefba73d ("mm/thp: remove code path which never got into")
5fb6c0683017 ("mm/thp: clean up lru_add_page_tail")
9d1d568727a8 ("mm/thp: move lru_add_page_tail func to huge_memory.c")
47eb331560ff ("mm/memcg: bail out early from swap accounting when memcg is disabled")
4b0d99a64d78 ("mm/memcg: warning on !memcg after readahead page charged")

--
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]