From: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
To: Qian Cai <cai-J5quhbR+WMc@public.gmane.org>
Cc: Alex Shi
<alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Vladimir Davydov
<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged
Date: Mon, 24 Aug 2020 17:10:45 +0200 [thread overview]
Message-ID: <20200824151045.GC3415@dhcp22.suse.cz> (raw)
In-Reply-To: <20200824145201.GB4337-J5quhbR+WMc@public.gmane.org>
On Mon 24-08-20 10:52:02, Qian Cai wrote:
> On Thu, Aug 20, 2020 at 10:58:50AM -0400, Qian Cai wrote:
> > On Tue, Aug 11, 2020 at 07:10:27PM +0800, Alex Shi wrote:
> > > Since readahead page is charged on memcg too, in theory we don't have to
> > > check this exception now. Before safely remove them all, add a warning
> > > for the unexpected !memcg.
> > >
> > > Signed-off-by: Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
> > > Acked-by: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
> >
> > This will trigger,
>
> Andrew, Stephen, can you drop this series for now? I did manage to trigger this
> warning on all arches, powerpc, x86 and arm64 (below).
Yes, I do agree. See http://lkml.kernel.org/r/20200824151013.GB3415-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-08-24 15:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 11:10 [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged Alex Shi
[not found] ` <1597144232-11370-1-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-11 11:10 ` [Resend PATCH 2/6] mm/memcg: remove useless check on page->mem_cgroup Alex Shi
2020-08-11 11:30 ` Michal Hocko
[not found] ` <20200811113008.GK4793-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-08-11 12:42 ` Alex Shi
2020-08-11 12:54 ` Alex Shi
[not found] ` <776b0e6f-4129-9fb9-0f66-47757cf320d5-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-11 13:56 ` Michal Hocko
2020-08-12 3:25 ` Alex Shi
[not found] ` <0b5e1ac3-c9c7-35e9-2661-b58430314d0a-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-13 6:20 ` Michal Hocko
[not found] ` <20200813062049.GA9477-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-08-13 9:45 ` Alex Shi
[not found] ` <abd9276b-31f8-a51d-43d6-6c8ae93237dc-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-13 11:01 ` Michal Hocko
2020-08-20 14:58 ` [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged Qian Cai
[not found] ` <20200820145850.GA4622-J5quhbR+WMc@public.gmane.org>
2020-08-21 8:01 ` Michal Hocko
[not found] ` <20200821080127.GD32537-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-08-21 12:39 ` Qian Cai
2020-08-21 13:48 ` Michal Hocko
[not found] ` <20200821134842.GF32537-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-08-21 14:01 ` Qian Cai
2020-08-24 15:10 ` Michal Hocko
[not found] ` <20200824151013.GB3415-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-08-25 1:25 ` Alex Shi
[not found] ` <12425e06-38ce-7ff4-28ce-b0418353fc67-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-25 2:04 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2008241849020.1171-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-08-27 6:00 ` Hugh Dickins
2020-08-25 7:25 ` Michal Hocko
2020-08-24 14:52 ` Qian Cai
[not found] ` <20200824145201.GB4337-J5quhbR+WMc@public.gmane.org>
2020-08-24 15:10 ` Michal Hocko [this message]
[not found] ` <20200824151045.GC3415-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-08-24 23:00 ` Stephen Rothwell
[not found] ` <20200825090054.3c5dd68a-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2020-08-24 23:14 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824151045.GC3415@dhcp22.suse.cz \
--to=mhocko-ibi9rg/b67k@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org \
--cc=cai-J5quhbR+WMc@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
--cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox