From: Qian Cai <cai-J5quhbR+WMc@public.gmane.org>
To: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: Alex Shi
<alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>,
mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org,
daniel.m.jordan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org,
richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org,
alexander.duyck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
rong.a.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
mhocko-IBi9RG/b67k@public.gmane.org,
vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
shy828301-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v18 00/32] per memcg lru_lock
Date: Mon, 24 Aug 2020 15:50:10 -0400 [thread overview]
Message-ID: <20200824195009.GE4337@lca.pw> (raw)
In-Reply-To: <20200824114204.cc796ca182db95809dd70a47-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
On Mon, Aug 24, 2020 at 11:42:04AM -0700, Andrew Morton wrote:
> On Mon, 24 Aug 2020 20:54:33 +0800 Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> wrote:
>
> > The new version which bases on v5.9-rc2. The first 6 patches was picked into
> > linux-mm, and add patch 25-32 that do some further post optimization.
>
> 32 patches, version 18. That's quite heroic. I'm unsure whether I
> should merge it up at this point - what do people think?
I certainly hope not given how buggy the previous reversion and Alex's other
patchset are. There is really no room for the shortcut this time.
>
> >
> > Following Daniel Jordan's suggestion, I have run 208 'dd' with on 104
> > containers on a 2s * 26cores * HT box with a modefied case:
> > https://git.kernel.org/pub/scm/linux/kernel/git/wfg/vm-scalability.git/tree/case-lru-file-readtwice
> > With this patchset, the readtwice performance increased about 80%
> > in concurrent containers.
>
> That's rather a slight amount of performance testing for a huge
> performance patchset! Is more detailed testing planned?
>
>
next prev parent reply other threads:[~2020-08-24 19:50 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 12:54 [PATCH v18 00/32] per memcg lru_lock Alex Shi
2020-08-24 12:54 ` [PATCH v18 02/32] mm/memcg: bail out early from swap accounting when memcg is disabled Alex Shi
2020-08-24 12:54 ` [PATCH v18 04/32] mm/thp: clean up lru_add_page_tail Alex Shi
2020-08-24 12:54 ` [PATCH v18 06/32] mm/thp: narrow lru locking Alex Shi
[not found] ` <1598273705-69124-7-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-09-10 13:49 ` Matthew Wilcox
[not found] ` <20200910134923.GR6583-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2020-09-11 3:37 ` Alex Shi
[not found] ` <514f6afa-dbf7-11c5-5431-1d558d2c20c9-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-09-13 15:27 ` Matthew Wilcox
2020-09-19 1:00 ` Hugh Dickins
2020-08-24 12:54 ` [PATCH v18 10/32] mm/compaction: rename compact_deferred as compact_should_defer Alex Shi
2020-08-24 12:54 ` [PATCH v18 11/32] mm/memcg: add debug checking in lock_page_memcg Alex Shi
2020-08-24 12:54 ` [PATCH v18 12/32] mm/memcg: optimize mem_cgroup_page_lruvec Alex Shi
2020-08-24 12:54 ` [PATCH v18 14/32] mm/lru: move lru_lock holding in func lru_note_cost_page Alex Shi
2020-08-24 12:54 ` [PATCH v18 15/32] mm/lru: move lock into lru_note_cost Alex Shi
[not found] ` <1598273705-69124-16-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-09-21 21:36 ` Hugh Dickins
2020-09-21 22:03 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2009211440570.5214-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-22 3:39 ` Alex Shi
[not found] ` <alpine.LSU.2.11.2009211434490.5214-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-22 3:38 ` Alex Shi
2020-08-24 12:54 ` [PATCH v18 17/32] mm/compaction: do page isolation first in compaction Alex Shi
2020-09-21 23:49 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2009211617080.5214-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-22 4:57 ` Alex Shi
2020-08-24 12:54 ` [PATCH v18 18/32] mm/thp: add tail pages into lru anyway in split_huge_page() Alex Shi
2020-08-24 12:54 ` [PATCH v18 19/32] mm/swap.c: serialize memcg changes in pagevec_lru_move_fn Alex Shi
[not found] ` <1598273705-69124-20-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-09-22 0:42 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2009211713440.5214-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-22 5:00 ` Alex Shi
2020-08-24 12:54 ` [PATCH v18 20/32] mm/lru: replace pgdat lru_lock with lruvec lock Alex Shi
[not found] ` <1598273705-69124-21-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-09-22 5:27 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2009211908080.6434-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-22 8:58 ` Alex Shi
2020-08-24 12:54 ` [PATCH v18 21/32] mm/lru: introduce the relock_page_lruvec function Alex Shi
[not found] ` <1598273705-69124-22-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-09-22 5:40 ` Hugh Dickins
2020-08-24 12:54 ` [PATCH v18 22/32] mm/vmscan: use relock for move_pages_to_lru Alex Shi
2020-09-22 5:44 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2009212240370.6434-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-23 1:55 ` Alex Shi
2020-08-24 12:54 ` [PATCH v18 24/32] mm/pgdat: remove pgdat lru_lock Alex Shi
2020-09-22 5:53 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2009212248350.6434-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-23 1:55 ` Alex Shi
2020-08-24 12:55 ` [PATCH v18 28/32] mm/compaction: Drop locked from isolate_migratepages_block Alex Shi
2020-08-24 12:55 ` [PATCH v18 30/32] mm: Drop use of test_and_set_skip in favor of just setting skip Alex Shi
[not found] ` <1598273705-69124-1-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-24 12:54 ` [PATCH v18 01/32] mm/memcg: warning on !memcg after readahead page charged Alex Shi
2020-08-24 12:54 ` [PATCH v18 03/32] mm/thp: move lru_add_page_tail func to huge_memory.c Alex Shi
2020-08-24 12:54 ` [PATCH v18 05/32] mm/thp: remove code path which never got into Alex Shi
2020-08-24 12:54 ` [PATCH v18 07/32] mm/swap.c: stop deactivate_file_page if page not on lru Alex Shi
2020-08-24 12:54 ` [PATCH v18 08/32] mm/vmscan: remove unnecessary lruvec adding Alex Shi
2020-08-24 12:54 ` [PATCH v18 09/32] mm/page_idle: no unlikely double check for idle page counting Alex Shi
2020-08-24 12:54 ` [PATCH v18 13/32] mm/swap.c: fold vm event PGROTATED into pagevec_move_tail_fn Alex Shi
2020-08-24 12:54 ` [PATCH v18 16/32] mm/lru: introduce TestClearPageLRU Alex Shi
[not found] ` <1598273705-69124-17-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-09-21 23:16 ` Hugh Dickins
2020-09-22 3:53 ` Alex Shi
2020-08-24 12:54 ` [PATCH v18 23/32] mm/lru: revise the comments of lru_lock Alex Shi
2020-09-22 5:48 ` Hugh Dickins
2020-08-24 12:54 ` [PATCH v18 25/32] mm/mlock: remove lru_lock on TestClearPageMlocked in munlock_vma_page Alex Shi
[not found] ` <1598273705-69124-26-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-26 5:52 ` Alex Shi
2020-09-22 6:13 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2009212253320.6434-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-23 1:58 ` Alex Shi
2020-08-24 12:54 ` [PATCH v18 26/32] mm/mlock: remove __munlock_isolate_lru_page Alex Shi
2020-08-24 12:55 ` [PATCH v18 27/32] mm/swap.c: optimizing __pagevec_lru_add lru_lock Alex Shi
2020-08-26 9:07 ` Alex Shi
2020-08-24 12:55 ` [PATCH v18 29/32] mm: Identify compound pages sooner in isolate_migratepages_block Alex Shi
2020-08-24 12:55 ` [PATCH v18 31/32] mm: Add explicit page decrement in exception path for isolate_lru_pages Alex Shi
[not found] ` <1598273705-69124-32-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-09-09 1:01 ` Matthew Wilcox
[not found] ` <20200909010118.GB6583-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2020-09-09 15:43 ` Alexander Duyck
[not found] ` <CAKgT0UcjNx=00OgAQNWezc7UjLmF2NcDH0p7kzZ5D23PaFrFXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-09-09 17:07 ` Matthew Wilcox
2020-09-09 18:24 ` Hugh Dickins
2020-09-09 20:15 ` Matthew Wilcox
[not found] ` <20200909201530.GM6583-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2020-09-09 21:05 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2009091100280.9020-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-09 21:17 ` Alexander Duyck
2020-08-24 12:55 ` [PATCH v18 32/32] mm: Split release_pages work into 3 passes Alex Shi
2020-08-24 18:42 ` [PATCH v18 00/32] per memcg lru_lock Andrew Morton
[not found] ` <20200824114204.cc796ca182db95809dd70a47-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2020-08-24 19:50 ` Qian Cai [this message]
2020-08-24 20:24 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2008241231460.1065-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-08-25 1:56 ` Daniel Jordan
[not found] ` <20200825015627.3c3pnwauqznnp3gc-S51bK0XF4qpuJJETbFA3a0B3C2bhBk7L0E9HWUfgJXw@public.gmane.org>
2020-08-25 3:26 ` Alex Shi
[not found] ` <ec62a835-f79d-2b8c-99c7-120834703b42-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-25 11:39 ` Matthew Wilcox
2020-08-26 1:19 ` Daniel Jordan
[not found] ` <20200826011946.spknwjt44d2szrdo-S51bK0XF4qpuJJETbFA3a0B3C2bhBk7L0E9HWUfgJXw@public.gmane.org>
2020-08-26 8:59 ` Alex Shi
[not found] ` <01ed6e45-3853-dcba-61cb-b429a49a7572-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-28 1:40 ` Daniel Jordan
2020-08-28 5:22 ` Alex Shi
[not found] ` <20200828014022.y5xju6weysqpzxd2-S51bK0XF4qpuJJETbFA3a0B3C2bhBk7L0E9HWUfgJXw@public.gmane.org>
2020-09-09 2:44 ` Aaron Lu
2020-09-09 11:40 ` Michal Hocko
2020-08-25 8:52 ` Alex Shi
[not found] ` <4cc9f54a-9eda-9966-df9a-a00bc9e88f4c-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-25 13:00 ` Alex Shi
2020-08-27 7:01 ` Hugh Dickins
2020-09-08 23:41 ` [PATCH v18 00/32] per memcg lru_lock: reviews Hugh Dickins
2020-09-09 15:08 ` Alex Shi
2020-09-09 23:16 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2009091524260.10087-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-11 2:50 ` Alex Shi
2020-09-12 2:13 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2009111634020.22739-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-13 14:21 ` Alex Shi
[not found] ` <5cfc6142-752d-26e6-0108-38d13009268b-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-09-15 8:21 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2009150112130.1550-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-15 16:58 ` Daniel Jordan
[not found] ` <20200915165807.kpp7uhiw7l3loofu-S51bK0XF4qpuJJETbFA3a0B3C2bhBk7L0E9HWUfgJXw@public.gmane.org>
2020-09-17 2:37 ` Alex Shi
[not found] ` <c3362c0a-3707-3a3d-9955-960d95f3ad8c-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-09-17 14:35 ` Daniel Jordan
[not found] ` <20200917143519.lhdfnoc47qrmbhaz-S51bK0XF4qpuJJETbFA3a0B3C2bhBk7L0E9HWUfgJXw@public.gmane.org>
2020-09-17 15:39 ` Alexander Duyck
[not found] ` <CAKgT0Ud8sYidvxtyrN3AFLs+-DiW7cuPGrKknaRicQsC8PLRtg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-09-17 16:48 ` Daniel Jordan
[not found] ` <61a42a87-eec9-e300-f710-992756f70de6-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-09-12 8:38 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2009112216260.23961-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-13 14:22 ` Alex Shi
[not found] ` <alpine.LSU.2.11.2009081640070.7256-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-09 2:24 ` Wei Yang
2020-09-09 16:11 ` Alexander Duyck
2020-09-10 0:32 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.2009091640490.10087-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-09-10 14:24 ` Alexander Duyck
[not found] ` <CAKgT0Ucive3RreD3TJt1Fjch_BH2ygFfUnpAJ_1BhsHy74w88g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-09-12 5:12 ` Hugh Dickins
2020-08-25 7:21 ` [PATCH v18 00/32] per memcg lru_lock Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824195009.GE4337@lca.pw \
--to=cai-j5quhbr+wmc@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org \
--cc=alexander.duyck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=daniel.m.jordan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org \
--cc=khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org \
--cc=kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org \
--cc=mhocko-IBi9RG/b67k@public.gmane.org \
--cc=richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=rong.a.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=shy828301-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).