Re: [PATCH 0/8] Return head pages from find_get_entry and find_lock_entry

William Kucharski
2020-08-21T17:37:49Z

> On Aug 19, 2020, at 12:48 PM, Matthew Wilcox (Oracle) <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> wrote:
>
> This patch seris started out as part of the THP patch set, but it has
> some nice effects along the way and it seems worth splitting it out and
> submitting separately.
>
> Currently find_get_entry() and find_lock_entry() return the page
> corresponding to the requested index, but the first thing most callers do
> is find the head page, which we just threw away. As part of auditing
> all the callers, I found some misuses of the APIs and some plain
> inefficiencies that I've fixed.
>
> The diffstat is unflattering, but I added more kernel-doc.
>
> Matthew Wilcox (Oracle) (8):
> mm: Factor find_get_swap_page out of mincore_page
> mm: Use find_get_swap_page in memcontrol
> mm: Optimise madvise WILLNEED
> proc: Optimise smaps for shmem entries
> i915: Use find_lock_page instead of find_lock_entry
> mm: Convert find_get_entry to return the head page
> mm: Return head page from find_lock_entry
> mm: Hoist find_subpage call further up in pagecache_get_page
>
> drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 4 +--
> fs/proc/task_mmu.c | 8 +----
> include/linux/pagemap.h | 16 +++++++--
> include/linux/swap.h | 7 ++++
> mm/filemap.c | 41 +++++++++++------------
> mm/madvise.c | 21 +++++++-----
> mm/memcontrol.c | 25 ++------------
> mm/mincore.c | 28 ++--------------
> mm/shmem.c | 15 +++++----
> mm/swap_state.c | 31 +++++++++++++++++
> 10 files changed, 98 insertions(+), 98 deletions(-)

For the series:

Reviewed-by: William Kucharski <william.kucharski-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>