public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Gabriel Krisman Bertazi
	<krisman-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	khazhy-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org
Subject: Re: [PATCH] blk-cgroup: Pre-allocate tree node on blkg_conf_prep
Date: Thu, 22 Oct 2020 15:42:50 -0400	[thread overview]
Message-ID: <20201022194250.GC5691@mtj.thefacebook.com> (raw)
In-Reply-To: <20201022182945.1679730-1-krisman-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>

On Thu, Oct 22, 2020 at 02:29:45PM -0400, Gabriel Krisman Bertazi wrote:
> @@ -657,6 +658,8 @@ int blkg_conf_prep(struct blkcg *blkcg, const struct blkcg_policy *pol,
>  			goto fail;
>  		}
>  
> +		preloaded = !radix_tree_preload(GFP_KERNEL);

I think we can just fail the function if GFP_KERNEL preload fails.

Thanks.

-- 
tejun

      parent reply	other threads:[~2020-10-22 19:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-22 18:29 [PATCH] blk-cgroup: Pre-allocate tree node on blkg_conf_prep Gabriel Krisman Bertazi
     [not found] ` <20201022182945.1679730-1-krisman-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-10-22 19:42   ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201022194250.GC5691@mtj.thefacebook.com \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
    --cc=khazhy-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=krisman-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox