From: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
To: Muchun Song <songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
Cc: hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
guro-b10kYP2dOMg@public.gmane.org,
iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org,
laoar.shao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
chris-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org,
christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org,
peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
esyr-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
areber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
elver-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org
Subject: Re: [PATCH v2] mm: memcontrol: Simplify the mem_cgroup_page_lruvec
Date: Thu, 29 Oct 2020 10:08:06 +0100 [thread overview]
Message-ID: <20201029090806.GD17500@dhcp22.suse.cz> (raw)
In-Reply-To: <20201028035013.99711-4-songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
On Wed 28-10-20 11:50:13, Muchun Song wrote:
[...]
> -struct lruvec *mem_cgroup_page_lruvec(struct page *page, struct pglist_data *pgdat)
> +static struct lruvec *
> +__mem_cgroup_node_lruvec(struct mem_cgroup *memcg, struct pglist_data *pgdat,
> + int nid)
I thought I have made it clear that this is not a good approach. Please
do not repost new version without that being addressed. If there are any
questions then feel free to ask for details.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-10-29 9:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 3:50 [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg Muchun Song
2020-10-28 3:50 ` [PATCH v2] mm: memcg/slab: Fix use after free in obj_cgroup_charge Muchun Song
[not found] ` <20201028035013.99711-2-songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
2020-10-29 15:52 ` Shakeel Butt
2020-11-10 3:19 ` Muchun Song
2020-10-28 3:50 ` [PATCH v2] mm: memcontrol: Simplify the mem_cgroup_page_lruvec Muchun Song
[not found] ` <20201028035013.99711-4-songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
2020-10-29 9:08 ` Michal Hocko [this message]
[not found] ` <20201029090806.GD17500-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-10-29 16:01 ` Shakeel Butt
[not found] ` <CALvZod68-f-_1pevYbegzXk_b0L=XbCJkM5KqcRF9TuLiz3_ww-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-10-29 16:13 ` Michal Hocko
2020-10-29 0:16 ` [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg Roman Gushchin
[not found] ` <20201028035013.99711-1-songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
2020-10-28 3:50 ` [PATCH v2] mm: memcg/slab: Rename *_lruvec_slab_state to *_lruvec_kmem_state Muchun Song
[not found] ` <20201028035013.99711-3-songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
2020-10-29 15:52 ` Shakeel Butt
2020-10-29 15:48 ` [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg Shakeel Butt
[not found] ` <CALvZod6p_y2fTEK5fzAL=JfPsguqYbttgWC4_GPc=rF1PsN6TQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-10-29 16:08 ` [External] " Muchun Song
[not found] ` <CAMZfGtW38sFcdpnx3Xx+RgRL37WzpQsq8qvfdnmhbh4H9Ex0cg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-10-29 16:18 ` Shakeel Butt
2020-10-29 16:32 ` Muchun Song
2020-10-29 17:09 ` Roman Gushchin
[not found] ` <20201029170955.GI827280-cx5fftMpWqeCjSd+JxjunQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2020-10-29 20:34 ` Shakeel Butt
[not found] ` <CALvZod65MhzQiwGgLM89_gZzCFDaeSZofn08viPgcvra0JRvSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-10-29 21:25 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029090806.GD17500@dhcp22.suse.cz \
--to=mhocko-ibi9rg/b67k@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=areber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=chris-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org \
--cc=christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org \
--cc=elver-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=esyr-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=guro-b10kYP2dOMg@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org \
--cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=laoar.shao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
--cc=surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox