From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail Date: Thu, 29 Oct 2020 09:50:47 -0400 Message-ID: <20201029135047.GE599825@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-5-git-send-email-alex.shi@linux.alibaba.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5MfKe3DP7slEVa5weBChPOdwKwukAel2TnvkgswMss4=; b=gcRq1IeIkaEAkPFS5WKi2EPbUk5OEhwyFRIn/uaI+vOq8JeipGnDYtfvu5hPSgvNMA +bd5ninFYWFlPInI6dcTy24RZXWatQtR7EajDSee3Gw76Ru+sshSeR7uDtaaOpAnzqht M+HgpBZJiUIUGmXcDxHju67QR5p3CRkGlQMQdbKGZLG0TkOfScdJMYnEufC4/tEPY/4K 36jdPDiqUEOkLh48UffqE2EAsI0wugobZ32NeGkq7pT7eOzUNkCemRWkTzOHU0CRlptw IR7EEi5NU9fJ3XOP0eUD7clmNTAYd5R+/cBVDyhT6Xw0+1wkeWcHtkoC1f8c7KJBf+0e Kc1g== Content-Disposition: inline In-Reply-To: <1603968305-8026-5-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alex Shi Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org, daniel.m.jordan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org, richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org, alexander.duyck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, rong.a.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mhocko-IBi9RG/b67k@public.gmane.org, vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, shy828301-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org On Thu, Oct 29, 2020 at 06:44:49PM +0800, Alex Shi wrote: > Since the first parameter is only used by head page, it's better to make > it explicit. > > Signed-off-by: Alex Shi > Reviewed-by: Kirill A. Shutemov > Acked-by: Hugh Dickins > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Hugh Dickins > Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > --- > mm/huge_memory.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 038db815ebba..93c0b73eb8c6 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2346,19 +2346,19 @@ static void remap_page(struct page *page, unsigned int nr) > } > } > > -static void lru_add_page_tail(struct page *page, struct page *page_tail, > +static void lru_add_page_tail(struct page *head, struct page *page_tail, It may be better to pick either head and tail or page_head and page_tail ?