From: Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>
To: Lukas Bulwahn <lukas.bulwahn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Vladimir Davydov
<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Tom Rix <trix-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Nathan Chancellor
<natechancellor-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Nick Desaulniers
<ndesaulniers-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
clang-built-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mm: memcg: remove obsolete memcg_has_children()
Date: Mon, 16 Nov 2020 13:12:24 -0800 [thread overview]
Message-ID: <20201116211224.GA45468@carbon.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201116055043.20886-1-lukas.bulwahn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Mon, Nov 16, 2020 at 06:50:43AM +0100, Lukas Bulwahn wrote:
> Commit 2ef1bf118c40 ("mm: memcg: deprecate the non-hierarchical mode")
> removed the only use of memcg_has_children() in
> mem_cgroup_hierarchy_write() as part of the feature deprecation.
>
> Hence, since then, make CC=clang W=1 warns:
>
> mm/memcontrol.c:3421:20:
> warning: unused function 'memcg_has_children' [-Wunused-function]
>
> Simply remove this obsolete unused function.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> applies cleanly on next-20201113, not on current master
>
> Roman, please ack.
Acked-by: Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>
Thanks!
next prev parent reply other threads:[~2020-11-16 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 5:50 [PATCH] mm: memcg: remove obsolete memcg_has_children() Lukas Bulwahn
[not found] ` <20201116055043.20886-1-lukas.bulwahn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-11-16 21:12 ` Roman Gushchin [this message]
2020-11-17 2:55 ` Nathan Chancellor
2020-11-18 12:46 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116211224.GA45468@carbon.dhcp.thefacebook.com \
--to=guro-b10kyp2domg@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=clang-built-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=lukas.bulwahn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=natechancellor-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ndesaulniers-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=trix-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox