From: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
To: Wei Yang <richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] cgroup/rstat: check updated_next only for root
Date: Wed, 5 Jan 2022 20:35:04 +0100 [thread overview]
Message-ID: <20220105193504.GD6464@blackbody.suse.cz> (raw)
In-Reply-To: <20211225000932.7253-2-richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Sat, Dec 25, 2021 at 12:09:32AM +0000, Wei Yang <richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> This means we can remove the check on ->updated_next, if we make sure
> the subtree from @root is on list, which could be done by checking
> updated_next for root.
Nice refactoring.
> @@ -96,9 +97,12 @@ static struct cgroup *cgroup_rstat_cpu_pop_updated(struct cgroup *pos,
> * We're gonna walk down to the first leaf and visit/remove it. We
> * can pick whatever unvisited node as the starting point.
> */
> - if (!pos)
> + if (!pos) {
> pos = root;
> - else
> + // return NULL if this subtree is not on-list
> + if (!cgroup_rstat_cpu(pos, cpu)->updated_next)
> + return NULL;
> + } else
+ /* return NULL if this subtree is not on-list */
Just a coding style nitpick.
The patch is otherwise
Reviewed-by: Michal Koutný <mkoutny-IBi9RG/b67k@public.gmane.org>
next prev parent reply other threads:[~2022-01-05 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 0:09 [PATCH 1/2] cgroup: rstat: explicitly put loop variant in while Wei Yang
[not found] ` <20211225000932.7253-1-richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-12-25 0:09 ` [PATCH 2/2] cgroup/rstat: check updated_next only for root Wei Yang
[not found] ` <20211225000932.7253-2-richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2022-01-05 19:35 ` Michal Koutný [this message]
[not found] ` <20220105193504.GD6464-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-01-06 0:35 ` Wei Yang
2022-01-06 21:55 ` Tejun Heo
2022-01-05 19:37 ` [PATCH 1/2] cgroup: rstat: explicitly put loop variant in while Michal Koutný
2022-01-06 21:10 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105193504.GD6464@blackbody.suse.cz \
--to=mkoutny-ibi9rg/b67k@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
--cc=richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox