public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
To: void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
	kernel-team-b10kYP2dOMg@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mkoutny-IBi9RG/b67k@public.gmane.org,
	roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org,
	shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	Richard Palethorpe <rpalethorpe-l3A5Bk7waGM@public.gmane.org>
Subject: [PATCH 3/4] selftests: memcg: Adjust expected reclaim values of protected cgroups
Date: Fri, 13 May 2022 19:18:10 +0200	[thread overview]
Message-ID: <20220513171811.730-4-mkoutny@suse.com> (raw)
In-Reply-To: <20220513171811.730-1-mkoutny-IBi9RG/b67k@public.gmane.org>

The numbers are not easy to derive in a closed form (certainly mere
protections ratios do not apply), therefore use a simulation to obtain
expected numbers.

The new values make the protection tests succeed more precisely.

	% run as: octave-cli script
	%
	% Input configurations
	% -------------------
	% E parent effective protection
	% n nominal protection of siblings set at the givel level
	% c current consumption -,,-

	% example from testcase (values in GB)
	E = 50 / 1024;
	n = [75 25 0 500 ] / 1024;
	c = [50 50 50 0] / 1024;

	% Reclaim parameters
	% ------------------

	% Minimal reclaim amount (GB)
	cluster = 32*4 / 2**20;

	% Reclaim coefficient (think as 0.5^sc->priority)
	alpha = .1

	% Simulation parameters
	% ---------------------
	epsilon = 1e-7;
	timeout = 1000;

	% Simulation loop
	% ---------------------
	% Simulation assumes siblings consumed the initial amount of memory (w/out
	% reclaim) and then the reclaim starts, all memory is reclaimable, i.e. treated
	% same. It simulates only non-low reclaim and assumes all memory.min = 0.

	ch = [];
	eh = [];
	rh = [];

	for t = 1:timeout
		% low_usage
		u = min(c, n);
		siblings = sum(u);

		% effective_protection()
		protected = min(n, c);                % start with nominal
		e = protected * min(1, E / siblings); % normalize overcommit

		% recursive protection
		unclaimed = max(0, E - siblings);
		parent_overuse = sum(c) - siblings;
		if (unclaimed > 0 && parent_overuse > 0)
			overuse = max(0, c - protected);
			e += unclaimed * (overuse / parent_overuse);
		endif

		% get_scan_count()
		r = alpha * c;             % assume all memory is in a single LRU list

		% commit 1bc63fb1272b ("mm, memcg: make scan aggression always exclude protection")
		sz = max(e, c);
		r .*= (1 - (e+epsilon) ./ (sz+epsilon));

		% uncomment to debug prints
		% e, c, r

		% nothing to reclaim, reached equilibrium
		if max(r) < epsilon
			break;
		endif

		% SWAP_CLUSTER_MAX
		r = max(r, (r > epsilon) .* cluster);
		% XXX here I do parallel reclaim of all siblings
		% in reality reclaim is serialized and each sibling recalculates own residual
		c = max(c - r, 0);

		ch = [ch ; c];
		eh = [eh ; e];
		rh = [rh ; r];
	endfor

	t
	c, e

Signed-off-by: Michal Koutn√Ω <mkoutny-IBi9RG/b67k@public.gmane.org>
---
 .../selftests/cgroup/test_memcontrol.c        | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c
index eba252fa64ac..9ffacf024bbd 100644
--- a/tools/testing/selftests/cgroup/test_memcontrol.c
+++ b/tools/testing/selftests/cgroup/test_memcontrol.c
@@ -260,9 +260,9 @@ static int cg_test_proc_killed(const char *cgroup)
  * memory pressure in it.
  *
  * A/B    memory.current ~= 50M
- * A/B/C  memory.current ~= 33M
- * A/B/D  memory.current ~= 17M
- * A/B/F  memory.current ~= 0
+ * A/B/C  memory.current ~= 29M
+ * A/B/D  memory.current ~= 21M
+ * A/B/E  memory.current ~= 0
  *
  * After that it tries to allocate more than there is
  * unprotected memory in A available, and checks
@@ -365,10 +365,10 @@ static int test_memcg_min(const char *root)
 	for (i = 0; i < ARRAY_SIZE(children); i++)
 		c[i] = cg_read_long(children[i], "memory.current");
 
-	if (!values_close(c[0], MB(33), 10))
+	if (!values_close(c[0], MB(29), 10))
 		goto cleanup;
 
-	if (!values_close(c[1], MB(17), 10))
+	if (!values_close(c[1], MB(21), 10))
 		goto cleanup;
 
 	if (c[3] != 0)
@@ -417,9 +417,9 @@ static int test_memcg_min(const char *root)
  *
  * Then it checks actual memory usages and expects that:
  * A/B    memory.current ~= 50M
- * A/B/   memory.current ~= 33M
- * A/B/D  memory.current ~= 17M
- * A/B/F  memory.current ~= 0
+ * A/B/   memory.current ~= 29M
+ * A/B/D  memory.current ~= 21M
+ * A/B/E  memory.current ~= 0
  *
  * After that it tries to allocate more than there is
  * unprotected memory in A available,
@@ -512,10 +512,10 @@ static int test_memcg_low(const char *root)
 	for (i = 0; i < ARRAY_SIZE(children); i++)
 		c[i] = cg_read_long(children[i], "memory.current");
 
-	if (!values_close(c[0], MB(33), 10))
+	if (!values_close(c[0], MB(29), 10))
 		goto cleanup;
 
-	if (!values_close(c[1], MB(17), 10))
+	if (!values_close(c[1], MB(21), 10))
 		goto cleanup;
 
 	if (c[3] != 0)
-- 
2.35.3


  parent reply	other threads:[~2022-05-13 17:18 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-23 15:56 [PATCH v2 0/5] Fix bugs in memcontroller cgroup tests David Vernet
2022-04-23 15:56 ` [PATCH v2 1/5] cgroups: Refactor children cgroups in memcg tests David Vernet
     [not found]   ` <20220423155619.3669555-2-void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
2022-04-26  1:56     ` Roman Gushchin
     [not found] ` <20220423155619.3669555-1-void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
2022-04-23 15:56   ` [PATCH v2 2/5] cgroup: Account for memory_recursiveprot in test_memcg_low() David Vernet
     [not found]     ` <20220423155619.3669555-3-void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
2022-04-27 14:09       ` Michal Koutný
     [not found]         ` <20220427140928.GD9823-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-04-29  1:03           ` David Vernet
     [not found]             ` <20220429010333.5rt2jwpiumnbuapf-2sxDN0k4oOr/D8ZFBB3Vemm1Eemhq0z/AL8bYrjMMd8@public.gmane.org>
2022-04-29  9:26               ` Michal Koutný
     [not found]                 ` <20220429092620.GA23621-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-05-06 16:40                   ` David Vernet
     [not found]                     ` <20220506164015.fsdsuv226nhllos5-2sxDN0k4oOr/D8ZFBB3Vemm1Eemhq0z/AL8bYrjMMd8@public.gmane.org>
2022-05-09 15:09                       ` Johannes Weiner
     [not found]                         ` <Ynkum8DeJIAtGi9y-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-05-10  0:44                           ` Andrew Morton
     [not found]                             ` <20220509174424.e43e695ffe0f7333c187fba8-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2022-05-10 17:43                               ` Michal Koutný
     [not found]                                 ` <20220510174341.GC24172-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-05-11 17:53                                   ` Johannes Weiner
     [not found]                                     ` <Ynv4AdjeVjptnjrH-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-05-12 17:27                                       ` Michal Koutný
2022-04-23 15:56   ` [PATCH v2 3/5] cgroup: Account for memory_localevents in test_memcg_oom_group_leaf_events() David Vernet
2022-04-23 15:56   ` [PATCH v2 4/5] cgroup: Removing racy check in test_memcg_sock() David Vernet
2022-04-23 15:56   ` [PATCH v2 5/5] cgroup: Fix racy check in alloc_pagecache_max_30M() helper function David Vernet
2022-05-12 17:04   ` [PATCH v2 0/5] Fix bugs in memcontroller cgroup tests Michal Koutný
     [not found]     ` <20220512170410.GA16096-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-05-12 17:30       ` David Vernet
     [not found]         ` <20220512173018.3pqlfwfigbbkoh4u-2sxDN0k4oOr/D8ZFBB3Vemm1Eemhq0z/AL8bYrjMMd8@public.gmane.org>
2022-05-12 17:44           ` David Vernet
     [not found]             ` <20220512174452.tr34tuh4k5jm6qjs-2sxDN0k4oOr/D8ZFBB3Vemm1Eemhq0z/AL8bYrjMMd8@public.gmane.org>
2022-05-13 17:18               ` [PATCH 0/4] memcontrol selftests fixups Michal Koutný
     [not found]                 ` <20220513171811.730-1-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-13 17:18                   ` [PATCH 1/4] selftests: memcg: Fix compilation Michal Koutný
     [not found]                     ` <20220513171811.730-2-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-13 17:40                       ` David Vernet
2022-05-13 18:53                       ` Roman Gushchin
2022-05-13 19:09                         ` Roman Gushchin
2022-05-13 17:18                   ` [PATCH 2/4] selftests: memcg: Expect no low events in unprotected sibling Michal Koutný
     [not found]                     ` <20220513171811.730-3-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-13 17:42                       ` David Vernet
2022-05-13 18:54                     ` Roman Gushchin
2022-05-18 15:54                       ` Michal Koutný
2022-05-13 17:18                   ` Michal Koutný [this message]
     [not found]                     ` <20220513171811.730-4-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-13 18:52                       ` [PATCH 3/4] selftests: memcg: Adjust expected reclaim values of protected cgroups Roman Gushchin
2022-05-13 17:18                   ` [PATCH 4/4] selftests: memcg: Remove protection from top level memcg Michal Koutný
     [not found]                     ` <20220513171811.730-5-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-13 18:59                       ` Roman Gushchin
2022-05-18  0:24                         ` Andrew Morton
     [not found]                           ` <20220517172443.3e524a8319c693ab24c5f22e-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2022-05-18  0:52                             ` Roman Gushchin
2022-05-18 15:44                               ` Michal Koutný
2022-05-13 19:14                       ` David Vernet
  -- strict thread matches above, loose matches on Subject: below --
2022-05-18 15:40 [PATCH 0/4] memcontrol selftests fixups Michal Koutný
     [not found] ` <20220518154037.18819-1-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-18 15:40   ` [PATCH 3/4] selftests: memcg: Adjust expected reclaim values of protected cgroups Michal Koutný

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220513171811.730-4-mkoutny@suse.com \
    --to=mkoutny-ibi9rg/b67k@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=kernel-team-b10kYP2dOMg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org \
    --cc=rpalethorpe-l3A5Bk7waGM@public.gmane.org \
    --cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox