From: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
To: void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mkoutny-IBi9RG/b67k@public.gmane.org,
roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org,
shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Richard Palethorpe <rpalethorpe-l3A5Bk7waGM@public.gmane.org>
Subject: [PATCH 4/4] selftests: memcg: Remove protection from top level memcg
Date: Fri, 13 May 2022 19:18:11 +0200 [thread overview]
Message-ID: <20220513171811.730-5-mkoutny@suse.com> (raw)
In-Reply-To: <20220513171811.730-1-mkoutny-IBi9RG/b67k@public.gmane.org>
The reclaim is triggered by memory limit in a subtree, therefore the
testcase does not need configured protection against external reclaim.
Also, correct/deduplicate respective comments
Signed-off-by: Michal Koutn√Ω <mkoutny-IBi9RG/b67k@public.gmane.org>
---
tools/testing/selftests/cgroup/test_memcontrol.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c
index 9ffacf024bbd..9d370aafd799 100644
--- a/tools/testing/selftests/cgroup/test_memcontrol.c
+++ b/tools/testing/selftests/cgroup/test_memcontrol.c
@@ -247,7 +247,7 @@ static int cg_test_proc_killed(const char *cgroup)
/*
* First, this test creates the following hierarchy:
- * A memory.min = 50M, memory.max = 200M
+ * A memory.min = 0, memory.max = 200M
* A/B memory.min = 50M, memory.current = 50M
* A/B/C memory.min = 75M, memory.current = 50M
* A/B/D memory.min = 25M, memory.current = 50M
@@ -257,7 +257,7 @@ static int cg_test_proc_killed(const char *cgroup)
* Usages are pagecache, but the test keeps a running
* process in every leaf cgroup.
* Then it creates A/G and creates a significant
- * memory pressure in it.
+ * memory pressure in A.
*
* A/B memory.current ~= 50M
* A/B/C memory.current ~= 29M
@@ -335,8 +335,6 @@ static int test_memcg_min(const char *root)
(void *)(long)fd);
}
- if (cg_write(parent[0], "memory.min", "50M"))
- goto cleanup;
if (cg_write(parent[1], "memory.min", "50M"))
goto cleanup;
if (cg_write(children[0], "memory.min", "75M"))
@@ -404,8 +402,8 @@ static int test_memcg_min(const char *root)
/*
* First, this test creates the following hierarchy:
- * A memory.low = 50M, memory.max = 200M
- * A/B memory.low = 50M, memory.current = 50M
+ * A memory.low = 0, memory.max = 200M
+ * A/B memory.low = 50M, memory.current = ...
* A/B/C memory.low = 75M, memory.current = 50M
* A/B/D memory.low = 25M, memory.current = 50M
* A/B/E memory.low = 0, memory.current = 50M
@@ -490,8 +488,6 @@ static int test_memcg_low(const char *root)
goto cleanup;
}
- if (cg_write(parent[0], "memory.low", "50M"))
- goto cleanup;
if (cg_write(parent[1], "memory.low", "50M"))
goto cleanup;
if (cg_write(children[0], "memory.low", "75M"))
--
2.35.3
next prev parent reply other threads:[~2022-05-13 17:18 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 15:56 [PATCH v2 0/5] Fix bugs in memcontroller cgroup tests David Vernet
2022-04-23 15:56 ` [PATCH v2 1/5] cgroups: Refactor children cgroups in memcg tests David Vernet
[not found] ` <20220423155619.3669555-2-void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
2022-04-26 1:56 ` Roman Gushchin
[not found] ` <20220423155619.3669555-1-void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
2022-04-23 15:56 ` [PATCH v2 2/5] cgroup: Account for memory_recursiveprot in test_memcg_low() David Vernet
[not found] ` <20220423155619.3669555-3-void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
2022-04-27 14:09 ` Michal Koutný
[not found] ` <20220427140928.GD9823-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-04-29 1:03 ` David Vernet
[not found] ` <20220429010333.5rt2jwpiumnbuapf-2sxDN0k4oOr/D8ZFBB3Vemm1Eemhq0z/AL8bYrjMMd8@public.gmane.org>
2022-04-29 9:26 ` Michal Koutný
[not found] ` <20220429092620.GA23621-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-05-06 16:40 ` David Vernet
[not found] ` <20220506164015.fsdsuv226nhllos5-2sxDN0k4oOr/D8ZFBB3Vemm1Eemhq0z/AL8bYrjMMd8@public.gmane.org>
2022-05-09 15:09 ` Johannes Weiner
[not found] ` <Ynkum8DeJIAtGi9y-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-05-10 0:44 ` Andrew Morton
[not found] ` <20220509174424.e43e695ffe0f7333c187fba8-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2022-05-10 17:43 ` Michal Koutný
[not found] ` <20220510174341.GC24172-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-05-11 17:53 ` Johannes Weiner
[not found] ` <Ynv4AdjeVjptnjrH-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-05-12 17:27 ` Michal Koutný
2022-04-23 15:56 ` [PATCH v2 3/5] cgroup: Account for memory_localevents in test_memcg_oom_group_leaf_events() David Vernet
2022-04-23 15:56 ` [PATCH v2 4/5] cgroup: Removing racy check in test_memcg_sock() David Vernet
2022-04-23 15:56 ` [PATCH v2 5/5] cgroup: Fix racy check in alloc_pagecache_max_30M() helper function David Vernet
2022-05-12 17:04 ` [PATCH v2 0/5] Fix bugs in memcontroller cgroup tests Michal Koutný
[not found] ` <20220512170410.GA16096-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-05-12 17:30 ` David Vernet
[not found] ` <20220512173018.3pqlfwfigbbkoh4u-2sxDN0k4oOr/D8ZFBB3Vemm1Eemhq0z/AL8bYrjMMd8@public.gmane.org>
2022-05-12 17:44 ` David Vernet
[not found] ` <20220512174452.tr34tuh4k5jm6qjs-2sxDN0k4oOr/D8ZFBB3Vemm1Eemhq0z/AL8bYrjMMd8@public.gmane.org>
2022-05-13 17:18 ` [PATCH 0/4] memcontrol selftests fixups Michal Koutný
[not found] ` <20220513171811.730-1-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-13 17:18 ` [PATCH 1/4] selftests: memcg: Fix compilation Michal Koutný
[not found] ` <20220513171811.730-2-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-13 17:40 ` David Vernet
2022-05-13 18:53 ` Roman Gushchin
2022-05-13 19:09 ` Roman Gushchin
2022-05-13 17:18 ` [PATCH 2/4] selftests: memcg: Expect no low events in unprotected sibling Michal Koutný
[not found] ` <20220513171811.730-3-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-13 17:42 ` David Vernet
2022-05-13 18:54 ` Roman Gushchin
2022-05-18 15:54 ` Michal Koutný
2022-05-13 17:18 ` [PATCH 3/4] selftests: memcg: Adjust expected reclaim values of protected cgroups Michal Koutný
[not found] ` <20220513171811.730-4-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-13 18:52 ` Roman Gushchin
2022-05-13 17:18 ` Michal Koutný [this message]
[not found] ` <20220513171811.730-5-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-13 18:59 ` [PATCH 4/4] selftests: memcg: Remove protection from top level memcg Roman Gushchin
2022-05-18 0:24 ` Andrew Morton
[not found] ` <20220517172443.3e524a8319c693ab24c5f22e-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2022-05-18 0:52 ` Roman Gushchin
2022-05-18 15:44 ` Michal Koutný
2022-05-13 19:14 ` David Vernet
-- strict thread matches above, loose matches on Subject: below --
2022-05-18 15:40 [PATCH 0/4] memcontrol selftests fixups Michal Koutný
[not found] ` <20220518154037.18819-1-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-18 15:40 ` [PATCH 4/4] selftests: memcg: Remove protection from top level memcg Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513171811.730-5-mkoutny@suse.com \
--to=mkoutny-ibi9rg/b67k@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org \
--cc=rpalethorpe-l3A5Bk7waGM@public.gmane.org \
--cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox