public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Ming Lei <ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH v3 0/2] blk-cgroup: Optimize blkcg_rstat_flush()
Date: Wed,  1 Jun 2022 17:18:22 -0400	[thread overview]
Message-ID: <20220601211824.89626-1-longman@redhat.com> (raw)

This is a follow-up of [1]. There is no change in patch 1. Patch 2 has
the following changes:
 - Update comments in patch 2.
 - Put rcu_read_lock/unlock() in blkcg_rstat_flush().
 - Use READ_ONCE/WRITE_ONCE() to access lnode->next to reduce data
   races.
 - Get a blkg reference when putting into the lockless list and put it
   back when removed.

[1] https://lore.kernel.org/lkml/20220601165324.60892-1-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org/

Waiman Long (2):
  blk-cgroup: Correctly free percpu iostat_cpu in blkg on error exit
  blk-cgroup: Optimize blkcg_rstat_flush()

 block/blk-cgroup.c | 92 ++++++++++++++++++++++++++++++++++++++++++----
 block/blk-cgroup.h |  9 +++++
 2 files changed, 93 insertions(+), 8 deletions(-)

-- 
2.31.1


             reply	other threads:[~2022-06-01 21:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01 21:18 Waiman Long [this message]
2022-06-01 21:18 ` [PATCH v3 1/2] blk-cgroup: Correctly free percpu iostat_cpu in blkg on error exit Waiman Long
     [not found] ` <20220601211824.89626-1-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-06-01 21:18   ` [PATCH v3 2/2] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
2022-06-01 21:26     ` Tejun Heo
2022-06-01 21:30       ` Waiman Long
2022-06-02  6:32     ` kernel test robot
2022-06-02  1:54   ` [PATCH v4 " Waiman Long
2022-06-02 13:35   ` [PATCH v5 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path Waiman Long
2022-06-02 16:16     ` Tejun Heo
     [not found]       ` <YpjiYPscJst5iuyv-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-06-02 17:17         ` Waiman Long
2022-06-02 13:35 ` [PATCH v5 0/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
2022-06-02 13:35 ` [PATCH v5 1/3] blk-cgroup: Correctly free percpu iostat_cpu in blkg on error exit Waiman Long
     [not found]   ` <20220602133543.128088-2-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-06-02 18:54     ` [PATCH v5 4/4] blk-cgroup: Document the design of new lockless iostat_cpu list Waiman Long
2022-06-02 19:05       ` Tejun Heo
     [not found]         ` <YpkJ6rDTR24ScuEq-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-06-02 19:12           ` Waiman Long
2022-06-02 13:35 ` [PATCH v5 3/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
2022-06-02 16:58   ` Tejun Heo
     [not found]     ` <YpjsTNZx4DG+kot4-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-06-02 17:26       ` Waiman Long
     [not found]         ` <42da456d-8f6a-3af0-4cd3-d33a07e3b81e-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-06-02 17:46           ` Tejun Heo
     [not found]             ` <Ypj3hcodkAU1MUR7-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-06-02 18:18               ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220601211824.89626-1-longman@redhat.com \
    --to=longman-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox