Re: [PATCH bpf-next v2 6/8] cgroup: bpf: enable bpf programs to integrate with rstat

kernel test robot
2022-06-11T10:22:03Z

Hi Yosry,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/bpf-rstat-cgroup-hierarchical-stats/20220611-034720
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: hexagon-randconfig-r012-20220611 (https://download.01.org/0day-ci/archive/20220611/202206111842.O3viR9gq-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project ff4abe755279a3a47cc416ef80dbc900d9a98a19)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/83f297e2b47dc41b511f071b9eadf38339387b41
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Yosry-Ahmed/bpf-rstat-cgroup-hierarchical-stats/20220611-034720
git checkout 83f297e2b47dc41b511f071b9eadf38339387b41
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash kernel/cgroup/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> kernel/cgroup/rstat.c:161:22: warning: no previous prototype for function 'bpf_rstat_flush' [-Wmissing-prototypes]
__weak noinline void bpf_rstat_flush(struct cgroup *cgrp,
^
kernel/cgroup/rstat.c:161:17: note: declare 'static' if the function is not intended to be used outside of this translation unit
__weak noinline void bpf_rstat_flush(struct cgroup *cgrp,
^
static
>> kernel/cgroup/rstat.c:509:3: error: field designator 'sleepable_set' does not refer to any field in type 'const struct btf_kfunc_id_set'
.sleepable_set = &bpf_rstat_sleepable_kfunc_ids,
^
1 warning and 1 error generated.

vim +509 kernel/cgroup/rstat.c

505
506 static const struct btf_kfunc_id_set bpf_rstat_kfunc_set = {
507 .owner = THIS_MODULE,
508 .check_set = &bpf_rstat_check_kfunc_ids,
> 509 .sleepable_set = &bpf_rstat_sleepable_kfunc_ids,
510 };
511

--
0-DAY CI Kernel Test Service