Re: [PATCH bpf-next v2 6/8] cgroup: bpf: enable bpf programs to integrate with rstat

Yosry Ahmed
2022-06-10T21:30:00Z

On Fri, Jun 10, 2022 at 2:23 PM kernel test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>
> Hi Yosry,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on bpf-next/master]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/bpf-rstat-cgroup-hierarchical-stats/20220611-034720
> base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220611/202206110544.D5cTU0WQ-lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org/config)
> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
> reproduce (this is a W=1 build):
> # https://github.com/intel-lab-lkp/linux/commit/83f297e2b47dc41b511f071b9eadf38339387b41
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Yosry-Ahmed/bpf-rstat-cgroup-hierarchical-stats/20220611-034720
> git checkout 83f297e2b47dc41b511f071b9eadf38339387b41
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> All errors (new ones prefixed by >>):
>
> kernel/cgroup/rstat.c:161:22: warning: no previous prototype for 'bpf_rstat_flush' [-Wmissing-prototypes]
> 161 | __weak noinline void bpf_rstat_flush(struct cgroup *cgrp,
> | ^~~~~~~~~~~~~~~
> >> kernel/cgroup/rstat.c:509:10: error: 'const struct btf_kfunc_id_set' has no member named 'sleepable_set'; did you mean 'release_set'?
> 509 | .sleepable_set = &bpf_rstat_sleepable_kfunc_ids,
> | ^~~~~~~~~~~~~
> | release_set
> kernel/cgroup/rstat.c:509:27: warning: excess elements in struct initializer
> 509 | .sleepable_set = &bpf_rstat_sleepable_kfunc_ids,
> | ^
> kernel/cgroup/rstat.c:509:27: note: (near initialization for 'bpf_rstat_kfunc_set')
>
>
> vim +509 kernel/cgroup/rstat.c
>
> 505
> 506 static const struct btf_kfunc_id_set bpf_rstat_kfunc_set = {
> 507 .owner = THIS_MODULE,
> 508 .check_set = &bpf_rstat_check_kfunc_ids,
> > 509 .sleepable_set = &bpf_rstat_sleepable_kfunc_ids,
> 510 };
> 511
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp

AFAICT these failures are because the patch series depends on a patch
in the mailing list [1] that is not in bpf-next, as explained by the
cover letter.

[1] https://lore.kernel.org/bpf/20220421140740.459558-5-benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org/