From mboxrd@z Thu Jan 1 00:00:00 1970 From: kernel test robot Subject: Re: [PATCH bpf-next v2 6/8] cgroup: bpf: enable bpf programs to integrate with rstat Date: Sat, 11 Jun 2022 05:22:41 +0800 Message-ID: <202206110544.D5cTU0WQ-lkp@intel.com> References: <20220610194435.2268290-7-yosryahmed@google.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654896179; x=1686432179; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4Fnfy4WtP9NWPenQZd12tioUwaC4f7ruohnjtYS/f3Q=; b=gMNVufcWr0NsKdGfIlVHsJGQWHmNQ55lPzmgwiZ1xgH+y26zNBhsDMPk r/ZfbdGDU8u4PtmshPjqt0JLXyuInqJJi7Wv1wa2MQQruYQLJhEdE23TD wOeU602XWeyx8vEVgOZ0z5QuFdxBXJDIAzLJcwWXkUt7gOBC2QpaKjcbF e1nmWW37vHY7qgTha398jLJC5wFVILvDh1WIcTx5IW/kEoimaVZkDMhqL 9tf6VsP5mxRDrgiOZwfWmSV6cqEo956+eIiV9XpJ/dZAwekk69gIu/j2W 8FoQyRpQug4v9xlVcSXZjrk4vnlufw3g6LhKAboIjoh3A7rMXDVC6olZa g==; Content-Disposition: inline In-Reply-To: <20220610194435.2268290-7-yosryahmed@google.com> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yosry Ahmed , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Hao Luo , Tejun Heo , Zefan Li , Johannes Weiner , Shuah Khan , Michal Hocko Cc: kbuild-all@lists.01.org, Roman Gushchin , David Rientjes , Stanislav Fomichev , Greg Thelen , Shakeel Butt , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, Yosry Ahmed Hi Yosry, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/bpf-rstat-cgroup-hierarchical-stats/20220611-034720 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220611/202206110544.D5cTU0WQ-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/83f297e2b47dc41b511f071b9eadf38339387b41 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Yosry-Ahmed/bpf-rstat-cgroup-hierarchical-stats/20220611-034720 git checkout 83f297e2b47dc41b511f071b9eadf38339387b41 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): kernel/cgroup/rstat.c:161:22: warning: no previous prototype for 'bpf_rstat_flush' [-Wmissing-prototypes] 161 | __weak noinline void bpf_rstat_flush(struct cgroup *cgrp, | ^~~~~~~~~~~~~~~ >> kernel/cgroup/rstat.c:509:10: error: 'const struct btf_kfunc_id_set' has no member named 'sleepable_set'; did you mean 'release_set'? 509 | .sleepable_set = &bpf_rstat_sleepable_kfunc_ids, | ^~~~~~~~~~~~~ | release_set kernel/cgroup/rstat.c:509:27: warning: excess elements in struct initializer 509 | .sleepable_set = &bpf_rstat_sleepable_kfunc_ids, | ^ kernel/cgroup/rstat.c:509:27: note: (near initialization for 'bpf_rstat_kfunc_set') vim +509 kernel/cgroup/rstat.c 505 506 static const struct btf_kfunc_id_set bpf_rstat_kfunc_set = { 507 .owner = THIS_MODULE, 508 .check_set = &bpf_rstat_check_kfunc_ids, > 509 .sleepable_set = &bpf_rstat_sleepable_kfunc_ids, 510 }; 511 -- 0-DAY CI Kernel Test Service https://01.org/lkp