From: "Michal Koutný" <mkoutny@suse.com>
To: Yu Kuai <yukuai3@huawei.com>
Cc: tj@kernel.org, axboe@kernel.dk, ming.lei@redhat.com,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH -next v5 3/8] blk-throttle: factor out code to calculate ios/bytes_allowed
Date: Wed, 22 Jun 2022 19:27:06 +0200 [thread overview]
Message-ID: <20220622172706.GA28777@blackbody.suse.cz> (raw)
In-Reply-To: <20220528064330.3471000-4-yukuai3@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
On Sat, May 28, 2022 at 02:43:25PM +0800, Yu Kuai <yukuai3@huawei.com> wrote:
> +static u64 calculate_bytes_allowed(u64 bps_limit,
> + unsigned long jiffy_elapsed_rnd)
Just noticed with all series applied this argument needn't be called
_rnd. (It's a nit.)
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-06-22 17:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 6:43 [PATCH -next v5 0/8] bugfix and cleanup for blk-throttle Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 4/8] blk-throttle: fix io hung due to config updates Yu Kuai
2022-06-22 17:26 ` Michal Koutný
2022-06-23 12:27 ` Yu Kuai
2022-06-23 16:26 ` Michal Koutný
[not found] ` <20220623162620.GB16004-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-06-25 8:36 ` Yu Kuai
[not found] ` <75b3cdcc-1aa3-7259-4900-f09a2a081716-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-06-25 16:41 ` Jens Axboe
2022-06-26 2:39 ` Yu Kuai
[not found] ` <7e14a11b-225e-13c4-35ff-762eafd20b70-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2022-07-05 11:42 ` Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 5/8] blk-throttle: use 'READ/WRITE' instead of '0/1' Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 6/8] blk-throttle: calling throtl_dequeue/enqueue_tg in pairs Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 7/8] blk-throttle: cleanup tg_update_disptime() Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 8/8] blk-throttle: clean up flag 'THROTL_TG_PENDING' Yu Kuai
[not found] ` <20220528064330.3471000-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-05-28 6:43 ` [PATCH -next v5 1/8] blk-throttle: fix that io throttle can only work for single bio Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 2/8] blk-throttle: prevent overflow while calculating wait time Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 3/8] blk-throttle: factor out code to calculate ios/bytes_allowed Yu Kuai
2022-06-22 17:27 ` Michal Koutný [this message]
[not found] ` <20220622172706.GA28777-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-06-23 12:03 ` Yu Kuai
2022-06-02 11:14 ` [PATCH -next v5 0/8] bugfix and cleanup for blk-throttle Yu Kuai
[not found] ` <244865d4-e7e7-432f-8e9c-248ab900d283-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-06-09 0:59 ` Yu Kuai
[not found] ` <66910926-39e8-85df-bd13-2ca6b2b03cac-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-06-17 1:15 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622172706.GA28777@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox