From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH] kernel: move from strlcpy with unused retval to strscpy Date: Thu, 18 Aug 2022 18:15:06 -0400 Message-ID: <20220818181506.0d838d02@gandalf.local.home> References: <20220818210202.8227-1-wsa+renesas@sang-engineering.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20220818210202.8227-1-wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" To: Wolfram Sang Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Tejun Heo , Zefan Li , Johannes Weiner , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Pet On Thu, 18 Aug 2022 23:02:01 +0200 Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org/ Grumble. "So it's a completely useless function if you can't implicitly trust the source string - but that is almost always why people think they should use it!" But in my cases I actually do trust the source string. They are all generated from the kernel (not user input). With the exception of the trace_inject, which I didn't write, and that should definitely be converted. But eh, I'm not going to argue this one. -- Steve