From: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
To: Yu Kuai <yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v8 4/4] blk-throttle: fix io hung due to configuration updates
Date: Tue, 23 Aug 2022 11:41:43 +0200 [thread overview]
Message-ID: <20220823094143.GA1729@blackbody.suse.cz> (raw)
In-Reply-To: <20220823033130.874230-5-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
Hello.
On Tue, Aug 23, 2022 at 11:31:30AM +0800, Yu Kuai <yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org> wrote:
> Signed-off-by: Yu Kuai <yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> ---
> block/blk-throttle.c | 58 +++++++++++++++++++++++++++++++++++++++-----
> block/blk-throttle.h | 9 +++++++
> 2 files changed, 61 insertions(+), 6 deletions(-)
I see v8 is just naming+comments [1] change, calculations remain, so it
can have
Reviewed-by: Michal Koutný <mkoutny-IBi9RG/b67k@public.gmane.org>
[1] I assume dropping of the overflow/signedness is intentional after
previous debate.
next prev parent reply other threads:[~2022-08-23 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 3:31 [PATCH v8 0/4] blk-throttle bugfix Yu Kuai
2022-08-23 3:31 ` [PATCH v8 2/4] blk-throttle: prevent overflow while calculating wait time Yu Kuai
[not found] ` <20220823033130.874230-1-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-08-23 3:31 ` [PATCH v8 1/4] blk-throttle: fix that io throttle can only work for single bio Yu Kuai
[not found] ` <20220823033130.874230-2-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-08-23 18:07 ` Tejun Heo
[not found] ` <YwUXTL+8E/sPcEUB-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-08-24 1:15 ` Yu Kuai
2022-08-25 18:15 ` Tejun Heo
2022-08-26 1:07 ` Yu Kuai
2022-08-23 3:31 ` [PATCH v8 3/4] blk-throttle: factor out code to calculate ios/bytes_allowed Yu Kuai
2022-08-23 3:31 ` [PATCH v8 4/4] blk-throttle: fix io hung due to configuration updates Yu Kuai
[not found] ` <20220823033130.874230-5-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-08-23 9:41 ` Michal Koutný [this message]
2022-08-23 18:08 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823094143.GA1729@blackbody.suse.cz \
--to=mkoutny-ibi9rg/b67k@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org \
--cc=yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox