From: "Michal Koutný" <mkoutny@suse.com>
To: Ofir Gal <ofir.gal@volumez.com>
Cc: ming.lei@redhat.com, axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
tj@kernel.org, yi.zhang@huawei.com, yukuai3@huawei.com,
Ofir Gal <ofir@gal.software>
Subject: Re: [PATCH -next] blk-throttle: enable io throttle for root in cgroup v2
Date: Mon, 6 Feb 2023 16:00:05 +0100 [thread overview]
Message-ID: <20230206150005.GA21332@blackbody.suse.cz> (raw)
In-Reply-To: <20230205155541.1320485-1-ofir.gal@volumez.com>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
On Sun, Feb 05, 2023 at 05:55:41PM +0200, Ofir Gal <ofir.gal@volumez.com> wrote:
> I have tried to limit the SSD on Server #1, but it seems that the NVME
> target kworkers are not affected unless I use Yu Kuai's patch.
>
> Can you elaborate on the issues with this patch or how the scenario
> described above can be done with cgroups v2?
The issue is that if there's a client that doesn't implement
self-throttling you cannot guarantee anything on the server side.
Hence the mechanism must exist on the server side.
The NVME target should charge IO to respective blkcg's (just a generic
advice, I'm not familiar with that interface; see also
kthread_associate_blkcg() use in loop device driver).
HTH,
Michal
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-02-06 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 9:30 [PATCH -next] blk-throttle: enable io throttle for root in cgroup v2 Yu Kuai
2022-01-26 17:29 ` Tejun Heo
[not found] ` <YfGE9L4i7DtNTo08-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-01-27 2:36 ` yukuai (C)
[not found] ` <235b0757-d322-2b6e-3ab6-ecc8c82f8f1e-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-02-01 17:20 ` Tejun Heo
2022-02-08 1:38 ` yukuai (C)
[not found] ` <32b6949d-60b1-82ce-ae44-1cf089a78276-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-02-08 18:49 ` Tejun Heo
2022-02-09 1:22 ` yukuai (C)
[not found] ` <34ae7d06-4f6b-73f7-7299-65cb8859aad8-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2023-02-06 15:10 ` Michal Koutný
[not found] ` <20220114093000.3323470-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-02-09 3:14 ` Ming Lei
2023-02-05 15:55 ` Ofir Gal
2023-02-06 15:00 ` Michal Koutný [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230206150005.GA21332@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=ofir.gal@volumez.com \
--cc=ofir@gal.software \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox