From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Ming Lei <ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Josef Bacik <josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org>,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andreas Herrmann <aherrmann-l3A5Bk7waGM@public.gmane.org>
Subject: Re: [PATCH 02/19] blk-cgroup: delay blk-cgroup initialization until add_disk
Date: Wed, 8 Feb 2023 07:35:52 +0100 [thread overview]
Message-ID: <20230208063552.GA15030@lst.de> (raw)
In-Reply-To: <Y+Ji4NL/WkTR8vml@T590>
On Tue, Feb 07, 2023 at 10:40:32PM +0800, Ming Lei wrote:
> because disk->root_blkg is freed & set as NULL in del_gendisk().
>
> by the following script:
>
> modprobe -r scsi_debug
> modprobe scsi_debug dev_size_mb=1024
>
> mkfs.xfs -f /dev/sdc #suppose sdc is the scsi debug disk
> mount /dev/sdc /mnt
> echo 1 > /sys/block/sdc/device/delete
> sleep 1
> umount /mnt
Thank,
I've sent a fix. Can you wire up your reproducer in blktests?
next prev parent reply other threads:[~2023-02-08 6:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 13:41 switch blk-cgroup to work on gendisk v3 Christoph Hellwig
2023-02-01 13:41 ` [PATCH 04/19] blk-cgroup: simplify blkg freeing from initialization failure paths Christoph Hellwig
[not found] ` <20230201134123.2656505-5-hch-jcswGhMUV9g@public.gmane.org>
2023-02-03 0:12 ` Tejun Heo
2023-02-01 13:41 ` [PATCH 05/19] blk-cgroup: remove the !bdi->dev check in blkg_dev_name Christoph Hellwig
2023-02-01 13:41 ` [PATCH 06/19] blk-cgroup: pin the gendisk in struct blkcg_gq Christoph Hellwig
2023-02-03 0:15 ` Tejun Heo
2023-02-01 13:41 ` [PATCH 07/19] blk-cgroup: store a gendisk to throttle in struct task_struct Christoph Hellwig
[not found] ` <20230201134123.2656505-8-hch-jcswGhMUV9g@public.gmane.org>
2023-02-03 0:17 ` Tejun Heo
[not found] ` <Y9xSs0Gf8Qcr9R7w-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2023-02-03 8:06 ` Christoph Hellwig
[not found] ` <20230201134123.2656505-1-hch-jcswGhMUV9g@public.gmane.org>
2023-02-01 13:41 ` [PATCH 01/19] block: don't call blk_throtl_stat_add for non-READ/WRITE commands Christoph Hellwig
2023-02-01 13:41 ` [PATCH 02/19] blk-cgroup: delay blk-cgroup initialization until add_disk Christoph Hellwig
[not found] ` <20230201134123.2656505-3-hch-jcswGhMUV9g@public.gmane.org>
2023-02-03 0:08 ` Tejun Heo
2023-02-07 14:40 ` Ming Lei
2023-02-08 6:35 ` Christoph Hellwig [this message]
[not found] ` <20230208063552.GA15030-jcswGhMUV9g@public.gmane.org>
2023-02-08 7:32 ` Ming Lei
2023-02-01 13:41 ` [PATCH 03/19] blk-cgroup: improve error unwinding in blkg_alloc Christoph Hellwig
[not found] ` <20230201134123.2656505-4-hch-jcswGhMUV9g@public.gmane.org>
2023-02-03 0:10 ` Tejun Heo
[not found] ` <Y9xQ33MtLhoxtPNv-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2023-02-03 8:04 ` Christoph Hellwig
2023-02-01 13:41 ` [PATCH 08/19] blk-wbt: pass a gendisk to wbt_{enable,disable}_default Christoph Hellwig
2023-02-01 13:41 ` [PATCH 10/19] blk-wbt: move private information from blk-wbt.h to blk-wbt.c Christoph Hellwig
2023-02-01 13:41 ` [PATCH 13/19] blk-rq-qos: make rq_qos_add and rq_qos_del more useful Christoph Hellwig
2023-02-01 13:41 ` [PATCH 14/19] blk-rq-qos: constify rq_qos_ops Christoph Hellwig
2023-02-01 13:41 ` [PATCH 17/19] blk-cgroup: pass a gendisk to pd_alloc_fn Christoph Hellwig
2023-02-01 13:41 ` [PATCH 18/19] blk-cgroup: pass a gendisk to blkg_lookup Christoph Hellwig
2023-02-01 13:41 ` [PATCH 09/19] blk-wbt: pass a gendisk to wbt_init Christoph Hellwig
2023-02-01 13:41 ` [PATCH 11/19] blk-wbt: open code wbt_queue_depth_changed in wbt_init Christoph Hellwig
2023-02-01 13:41 ` [PATCH 12/19] blk-rq-qos: move rq_qos_add and rq_qos_del out of line Christoph Hellwig
2023-02-01 13:41 ` [PATCH 15/19] blk-rq-qos: store a gendisk instead of request_queue in struct rq_qos Christoph Hellwig
2023-02-01 13:41 ` [PATCH 16/19] blk-cgroup: pass a gendisk to blkcg_{de,}activate_policy Christoph Hellwig
2023-02-01 13:41 ` [PATCH 19/19] blk-cgroup: move the cgroup information to struct gendisk Christoph Hellwig
2023-02-03 0:24 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2023-02-03 15:03 switch blk-cgroup to work on gendisk v4 Christoph Hellwig
[not found] ` <20230203150400.3199230-1-hch-jcswGhMUV9g@public.gmane.org>
2023-02-03 15:03 ` [PATCH 02/19] blk-cgroup: delay blk-cgroup initialization until add_disk Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208063552.GA15030@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=aherrmann-l3A5Bk7waGM@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox