public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Zefan Li <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Christian Brauner
	<brauner-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Juri Lelli <juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Dietmar Eggemann <dietmar.eggemann-5wv7dgnIgG8@public.gmane.org>,
	gscrivan-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH 2/3] cgroup/cpuset: Make cpuset_attach_task() skip subpartitions CPUs for top_cpuset
Date: Fri, 31 Mar 2023 10:50:44 -0400	[thread overview]
Message-ID: <20230331145045.2251683-3-longman@redhat.com> (raw)
In-Reply-To: <20230331145045.2251683-1-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

It is found that attaching a task to the top_cpuset does not currently
ignore CPUs allocated to subpartitions in cpuset_attach_task(). So the
code is changed to fix that.

Signed-off-by: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 kernel/cgroup/cpuset.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index f6d5614982d7..2367de611c42 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -2530,7 +2530,8 @@ static void cpuset_attach_task(struct cpuset *cs, struct task_struct *task)
 	if (cs != &top_cpuset)
 		guarantee_online_cpus(task, cpus_attach);
 	else
-		cpumask_copy(cpus_attach, task_cpu_possible_mask(task));
+		cpumask_andnot(cpus_attach, task_cpu_possible_mask(task),
+			       cs->subparts_cpus);
 	/*
 	 * can_attach beforehand should guarantee that this doesn't
 	 * fail.  TODO: have a better way to handle failure here
-- 
2.31.1


  parent reply	other threads:[~2023-03-31 14:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31 14:50 [PATCH 0/3] cgroup/cpuset: Fix CLONE_INTO_CGROUP problem & other issues Waiman Long
2023-03-31 14:50 ` [PATCH 1/3] cgroup/cpuset: Make cpuset_fork() handle CLONE_INTO_CGROUP properly Waiman Long
     [not found]   ` <20230331145045.2251683-2-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-04-03 16:55     ` Michal Koutný
2023-04-03 17:18       ` Waiman Long
     [not found]         ` <d9f0005c-6825-b2a0-eac3-fcbad6e32b2f-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-04-03 17:29           ` Waiman Long
2023-04-04  9:19           ` Michal Koutný
2023-04-04 13:52             ` Waiman Long
2023-04-04 17:26               ` Waiman Long
2023-04-06  9:45     ` Christian Brauner
2023-04-06 14:08       ` Waiman Long
2023-04-06  2:51   ` kernel test robot
     [not found]     ` <202304061003.e5e0dc9c-yujie.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2023-04-06 12:17       ` Waiman Long
     [not found] ` <20230331145045.2251683-1-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-03-31 14:50   ` Waiman Long [this message]
     [not found]     ` <20230331145045.2251683-3-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-04-03 16:35       ` [PATCH 2/3] cgroup/cpuset: Make cpuset_attach_task() skip subpartitions CPUs for top_cpuset Michal Koutný
2023-03-31 14:50   ` [PATCH 3/3] cgroup/cpuset: Allow only one active attach operation per cpuset Waiman Long
     [not found]     ` <20230331145045.2251683-4-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-04-03 16:47       ` Michal Koutný
2023-04-03 17:41         ` Waiman Long
     [not found]           ` <24b67530-62ce-4f9c-7b74-d41d2ccc710e-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-04-04  9:07             ` Michal Koutný
2023-04-04 14:12               ` Waiman Long
2023-04-06  9:44       ` Christian Brauner
2023-04-07 15:30         ` Waiman Long
     [not found]           ` <89853ab9-7759-11bf-f751-28ce81a4f02e-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-04-09 11:46             ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230331145045.2251683-3-longman@redhat.com \
    --to=longman-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=brauner-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dietmar.eggemann-5wv7dgnIgG8@public.gmane.org \
    --cc=gscrivan-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox