public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Qais Yousef <qyousef-wp2msK0BRk8tq7phqP6ubQ@public.gmane.org>
To: Juri Lelli <juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Xuewen Yan <xuewen.yan94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Zefan Li <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Hao Luo <haoluo-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Dietmar Eggemann <dietmar.eggemann-5wv7dgnIgG8@public.gmane.org>,
	Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	luca.abeni-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org,
	claudio-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org,
	tommaso.cucinotta-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org,
	bristot-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Vincent Guittot
	<vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Wei Wang <wvw-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Rick Yiu <rickyiu-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Quentin Perret <qperret-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Heiko Carstens <hca-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>,
	Vasily Gorbik <gor-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
Subject: Re: [PATCH 2/6] sched/cpuset: Bring back cpuset_mutex
Date: Fri, 28 Apr 2023 12:22:16 +0100	[thread overview]
Message-ID: <20230428112216.cftofdixwbl4hufm@airbuntu> (raw)
In-Reply-To: <ZEoN1wq47uhE201p-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>

On 04/27/23 07:53, Juri Lelli wrote:
> Hi,
> 
> On 27/04/23 10:58, Xuewen Yan wrote:
> > HI Juri,
> > 
> > Would this patch be merged tobe stable-rc? In kernel5.15, we also find
> > that the rwsem would be blocked for a long  time, when we change the
> > task's cpuset cgroup.
> > And when we revert to the mutex, the delay would disappear.
> 
> Honestly, I'm not sure. This change is mostly improving performance, but
> it is also true that it's fixing some priority inheritance corner cases.
> So, I'm not sure it qualifies for stable, but it would be probably good to
> have it there.

I'm under the impression we need the whole lot back to stable, no? I'm not sure
if we can decouple this patch from the rest.

FWIW, I did my testing on 5.15 - so we can definitely help with the backport
and testing for 5.15 and 5.10.


Thanks!

  parent reply	other threads:[~2023-04-28 11:22 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 12:55 [PATCH 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Juri Lelli
2023-03-29 12:55 ` [PATCH 3/6] sched/cpuset: Keep track of SCHED_DEADLINE task in cpusets Juri Lelli
     [not found]   ` <20230329125558.255239-4-juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-04-04 20:06     ` Qais Yousef
2023-10-09 11:43   ` Xia Fukun
2023-10-09 15:26     ` Waiman Long
     [not found] ` <20230329125558.255239-1-juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-03-29 12:55   ` [PATCH 1/6] cgroup/cpuset: Rename functions dealing with DEADLINE accounting Juri Lelli
2023-04-04 20:05     ` Qais Yousef
2023-03-29 12:55   ` [PATCH 2/6] sched/cpuset: Bring back cpuset_mutex Juri Lelli
     [not found]     ` <20230329125558.255239-3-juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-04-04 17:31       ` Waiman Long
     [not found]         ` <fa585497-5c6d-f0ed-bdda-c71a81d315ad-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-04-26 11:57           ` Juri Lelli
2023-04-26 14:05             ` Waiman Long
     [not found]               ` <d53a8af3-46e7-fe6e-5cdd-0421796f80d2-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-04-27  2:58                 ` Xuewen Yan
     [not found]                   ` <CAB8ipk-ns=d+jNkKi1sjkSQmQidziCj34COkHZt6ZkRiG47HHA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-04-27  5:53                     ` Juri Lelli
     [not found]                       ` <ZEoN1wq47uhE201p-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2023-04-27 11:50                         ` Xuewen Yan
2023-04-28 11:22                         ` Qais Yousef [this message]
2023-04-26 14:31             ` Daniel Bristot de Oliveira
2023-04-04 20:05       ` Qais Yousef
2023-03-29 12:55   ` [PATCH 4/6] sched/deadline: Create DL BW alloc, free & check overflow interface Juri Lelli
     [not found]     ` <20230329125558.255239-5-juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-03-29 14:24       ` Waiman Long
2023-03-29 12:55   ` [PATCH 5/6] cgroup/cpuset: Free DL BW in case can_attach() fails Juri Lelli
2023-03-29 14:25     ` Waiman Long
     [not found]       ` <f8dfc30b-5079-2f44-7ab1-42ac25bd48b7-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-03-29 14:31         ` Waiman Long
     [not found]           ` <f8baea06-eeda-439a-3699-1cad7cde659e-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-03-29 16:39             ` Dietmar Eggemann
     [not found]               ` <cdede77a-5dc5-8933-a444-a2046b074b12-5wv7dgnIgG8@public.gmane.org>
2023-03-29 18:09                 ` Waiman Long
     [not found]                   ` <b7ad39b1-c615-3ebc-6980-d9db0f2ab0a0-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-03-30 15:14                     ` Dietmar Eggemann
     [not found]                       ` <5ff103f9-1366-0a9b-bd97-419ced1de07f-5wv7dgnIgG8@public.gmane.org>
2023-03-30 16:13                         ` Waiman Long
2023-03-29 12:55   ` [PATCH 6/6] cgroup/cpuset: Iterate only if DEADLINE tasks are present Juri Lelli
     [not found]     ` <20230329125558.255239-7-juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-04-04 20:06       ` Qais Yousef
2023-04-26 11:58         ` Juri Lelli
2023-03-29 14:34   ` [PATCH 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Waiman Long
2023-03-29 16:02   ` [PATCH 6/7] cgroup/cpuset: Protect DL BW data against parallel cpuset_attach() Waiman Long
2023-03-29 16:05     ` Waiman Long
     [not found]     ` <20230329160240.2093277-1-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-03-30 13:34       ` Dietmar Eggemann
2023-04-04 20:09   ` [PATCH 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Qais Yousef
2023-04-18 14:11   ` Qais Yousef
2023-04-18 14:31     ` Waiman Long
     [not found]       ` <eda74c03-bde2-bb51-2b0d-df2097215696-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-04-20 14:15         ` Juri Lelli
  -- strict thread matches above, loose matches on Subject: below --
2023-08-20 15:21 [PATCH 0/6] Backport rework of deadline bandwidth restoration for 5.10.y Qais Yousef
     [not found] ` <20230820152144.517461-1-qyousef-wp2msK0BRk8tq7phqP6ubQ@public.gmane.org>
2023-08-20 15:21   ` [PATCH 2/6] sched/cpuset: Bring back cpuset_mutex Qais Yousef
2023-08-20 15:22 [PATCH 0/6] Backport rework of deadline bandwidth restoration for 5.15.y Qais Yousef
2023-08-20 15:22 ` [PATCH 2/6] sched/cpuset: Bring back cpuset_mutex Qais Yousef
2023-08-20 15:24 [PATCH 0/6] Backport rework of deadline bandwidth restoration for 6.1.y Qais Yousef
2023-08-20 15:24 ` [PATCH 2/6] sched/cpuset: Bring back cpuset_mutex Qais Yousef
2023-08-21 22:19 [PATCH 0/6] Backport rework of deadline bandwidth restoration for 6.4.y Qais Yousef
2023-08-21 22:19 ` [PATCH 2/6] sched/cpuset: Bring back cpuset_mutex Qais Yousef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230428112216.cftofdixwbl4hufm@airbuntu \
    --to=qyousef-wp2msk0brk8tq7phqp6ubq@public.gmane.org \
    --cc=bristot-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=claudio-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org \
    --cc=dietmar.eggemann-5wv7dgnIgG8@public.gmane.org \
    --cc=gor-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=haoluo-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=hca-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
    --cc=juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
    --cc=longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=luca.abeni-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org \
    --cc=mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=qperret-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=rickyiu-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=tommaso.cucinotta-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org \
    --cc=vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=wvw-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=xuewen.yan94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox