From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH v2 2/6] sched/cpuset: Bring back cpuset_mutex Date: Thu, 4 May 2023 08:21:05 +0200 Message-ID: <20230504062105.GD1734100@hirez.programming.kicks-ass.net> References: <20230503072228.115707-1-juri.lelli@redhat.com> <20230503072228.115707-3-juri.lelli@redhat.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EEV4A2euqpSIeKXuHLHCUtET3TmfqslPKI8OraMGh2M=; b=Fc3ToHirKdtr3r8sc3aqgus1nG bEncSEtMI/O87Wo9MYqGNpmvhouh6+Jr/Y7vXA0g74Zy7XfMCLTPiTCfadl8WpOkpkaghd6TiFsAH gCHGMjltQwdKL6wf+a243jLVorzaw0USjRDgVSmvBurP+7x05jHqaV7eWqrFFnUp6GUVDqdpr0+a5 LqWxwQeqJ+z89tyuoieb+VVCguopLytE6w+9XtcxaheKSAmFzs6ILzCMQbwlVjooPF8FljV0+E6P5 +aczBOVRvNHkJ9HAlDRTV+PEIYt8Ctq63KdshN8G+DEMGkRzx7ZMHdELAyWimDomr5YGTIGJ+weuj /OyQRKsQ==; Content-Disposition: inline In-Reply-To: <20230503072228.115707-3-juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Juri Lelli Cc: Ingo Molnar , Qais Yousef , Waiman Long , Tejun Heo , Zefan Li , Johannes Weiner , Hao Luo , Dietmar Eggemann , Steven Rostedt , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, luca.abeni-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org, claudio-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org, tommaso.cucinotta-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org, bristot-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vincent Guittot , Wei Wang , Rick Yiu , Quentin Perret , Heiko Carstens , Vasily Gorbik , Alexander Gordeev On Wed, May 03, 2023 at 09:22:24AM +0200, Juri Lelli wrote: > Turns out percpu_cpuset_rwsem - commit 1243dc518c9d ("cgroup/cpuset: > Convert cpuset_mutex to percpu_rwsem") - wasn't such a brilliant idea, > as it has been reported to cause slowdowns in workloads that need to > change cpuset configuration frequently and it is also not implementing > priority inheritance (which causes troubles with realtime workloads). What were they doing ? Dynamically adjusting the DL parameters?