Re: [PATCH] memcg: remove unneeded header files

[kernel test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

Hi Miaohe,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.4-rc6 next-20230616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Miaohe-Lin/memcg-remove-unneeded-header-files/20230617-152922
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20230617072658.1826560-1-linmiaohe%40huawei.com
patch subject: [PATCH] memcg: remove unneeded header files
config: i386-randconfig-i012-20230617 (https://download.01.org/0day-ci/archive/20230617/202306171711.3ZCE2wVo-lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce: (https://download.01.org/0day-ci/archive/20230617/202306171711.3ZCE2wVo-lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306171711.3ZCE2wVo-lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org/

All errors (new ones prefixed by >>):

>> mm/memcontrol.c:5447:2: error: call to undeclared function 'wb_memcg_offline'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
           wb_memcg_offline(memcg);
           ^
>> mm/memcontrol.c:5788:8: error: call to undeclared function 'mapping_can_writeback'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
                           if (mapping_can_writeback(mapping)) {
                               ^
   mm/memcontrol.c:5788:8: note: did you mean 'mapping_map_writable'?
   include/linux/fs.h:545:19: note: 'mapping_map_writable' declared here
   static inline int mapping_map_writable(struct address_space *mapping)
                     ^
   2 errors generated.


vim +/wb_memcg_offline +5447 mm/memcontrol.c

8cdea7c0545426 Balbir Singh      2008-02-07  5424  
eb95419b023aba Tejun Heo         2013-08-08  5425  static void mem_cgroup_css_offline(struct cgroup_subsys_state *css)
df878fb04dea04 KAMEZAWA Hiroyuki 2008-02-07  5426  {
eb95419b023aba Tejun Heo         2013-08-08  5427  	struct mem_cgroup *memcg = mem_cgroup_from_css(css);
3bc942f372af38 Tejun Heo         2013-11-22  5428  	struct mem_cgroup_event *event, *tmp;
79bd9814e5ec9a Tejun Heo         2013-11-22  5429  
79bd9814e5ec9a Tejun Heo         2013-11-22  5430  	/*
79bd9814e5ec9a Tejun Heo         2013-11-22  5431  	 * Unregister events and notify userspace.
79bd9814e5ec9a Tejun Heo         2013-11-22  5432  	 * Notify userspace about cgroup removing only after rmdir of cgroup
79bd9814e5ec9a Tejun Heo         2013-11-22  5433  	 * directory to avoid race between userspace and kernelspace.
79bd9814e5ec9a Tejun Heo         2013-11-22  5434  	 */
4ba9515d32bac1 Shakeel Butt      2021-09-02  5435  	spin_lock_irq(&memcg->event_list_lock);
fba94807837850 Tejun Heo         2013-11-22  5436  	list_for_each_entry_safe(event, tmp, &memcg->event_list, list) {
79bd9814e5ec9a Tejun Heo         2013-11-22  5437  		list_del_init(&event->list);
79bd9814e5ec9a Tejun Heo         2013-11-22  5438  		schedule_work(&event->remove);
79bd9814e5ec9a Tejun Heo         2013-11-22  5439  	}
4ba9515d32bac1 Shakeel Butt      2021-09-02  5440  	spin_unlock_irq(&memcg->event_list_lock);
ec64f51545fffb KAMEZAWA Hiroyuki 2009-04-02  5441  
bf8d5d52ffe89a Roman Gushchin    2018-06-07  5442  	page_counter_set_min(&memcg->memory, 0);
230671533d6463 Roman Gushchin    2018-06-07  5443  	page_counter_set_low(&memcg->memory, 0);
63677c745d63ba Roman Gushchin    2017-09-06  5444  
567e9ab2e614e5 Johannes Weiner   2016-01-20  5445  	memcg_offline_kmem(memcg);
a178015cde6998 Yang Shi          2021-05-04  5446  	reparent_shrinker_deferred(memcg);
52ebea749aaed1 Tejun Heo         2015-05-22 @5447  	wb_memcg_offline(memcg);
e4dde56cd20867 Yu Zhao           2022-12-21  5448  	lru_gen_offline_memcg(memcg);
73f576c04b9410 Johannes Weiner   2016-07-20  5449  
591edfb10a949d Roman Gushchin    2018-10-26  5450  	drain_all_stock(memcg);
591edfb10a949d Roman Gushchin    2018-10-26  5451  
73f576c04b9410 Johannes Weiner   2016-07-20  5452  	mem_cgroup_id_put(memcg);
df878fb04dea04 KAMEZAWA Hiroyuki 2008-02-07  5453  }
df878fb04dea04 KAMEZAWA Hiroyuki 2008-02-07  5454  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki