From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CED091C11; Wed, 8 Nov 2023 12:35:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RLUAajSf" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF76F1BF2; Wed, 8 Nov 2023 04:35:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699446935; x=1730982935; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Oh/p14wVpiK4vO4Z0TdtqDDkwu7eO/RsM3cVxkN0aNU=; b=RLUAajSfldQSdipsNswpZXsqZdt7RkizHRXANaCFQq57PsV+bUPPTRMK e2EK+QORXT/B1aWIeHiRLtBNXF/Sm1Kd30g5uNm995U2QmvENl0Dr5TVG upWpGEuTEDUTGYbx43H7pjoZXlEQAANFcIiLDsX946qnIvlj0rXDFYtjP rmXTKlKa3+hLzvSLFIyRAJtvNCVlGldkS38w72poY3jCGZp8AcV5HteeF Lim9Aa8CWK9St6ywobsWPxpssr+oa/34oHsfrcU1olp4qlvfUS74pLS9G kv5DY5YWROfhO+zTPPtG2wpSGQyIxZzgk+YZgbWvewJDUFcqKRTPH3ccP A==; X-IronPort-AV: E=McAfee;i="6600,9927,10887"; a="392622808" X-IronPort-AV: E=Sophos;i="6.03,286,1694761200"; d="scan'208";a="392622808" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2023 04:35:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,286,1694761200"; d="scan'208";a="4174110" Received: from lkp-server01.sh.intel.com (HELO 17d9e85e5079) ([10.239.97.150]) by orviesa002.jf.intel.com with ESMTP; 08 Nov 2023 04:35:30 -0800 Received: from kbuild by 17d9e85e5079 with local (Exim 4.96) (envelope-from ) id 1r0hmH-0007vc-2R; Wed, 08 Nov 2023 12:35:25 +0000 Date: Wed, 8 Nov 2023 20:34:38 +0800 From: kernel test robot To: Huan Yang , Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , David Hildenbrand , Matthew Wilcox , Huang Ying , Yosry Ahmed , Kefeng Wang , Peter Xu , "Vishal Moola (Oracle)" , Liu Shixin , Yue Zhao , Hugh Dickins , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , opensource.kernel@vivo.com, Huan Yang Subject: Re: [PATCH 2/4] mm: multi-gen LRU: MGLRU unbalance reclaim Message-ID: <202311082048.zacOzITP-lkp@intel.com> References: <20231108065818.19932-3-link@vivo.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108065818.19932-3-link@vivo.com> Hi Huan, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] [also build test WARNING on tj-cgroup/for-next linus/master v6.6 next-20231108] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Huan-Yang/mm-vmscan-LRU-unbalance-cgroup-reclaim/20231108-151757 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20231108065818.19932-3-link%40vivo.com patch subject: [PATCH 2/4] mm: multi-gen LRU: MGLRU unbalance reclaim config: x86_64-randconfig-011-20231108 (https://download.01.org/0day-ci/archive/20231108/202311082048.zacOzITP-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231108/202311082048.zacOzITP-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311082048.zacOzITP-lkp@intel.com/ All warnings (new ones prefixed by >>): mm/vmscan.c: In function 'isolate_folios': >> mm/vmscan.c:4518:29: warning: 'unbalance' is used uninitialized [-Wuninitialized] 4518 | if (scanned || unbalance) | ~~~~~~~~^~~~~~~~~~~~ mm/vmscan.c:4488:14: note: 'unbalance' was declared here 4488 | bool unbalance; | ^~~~~~~~~ vim +/unbalance +4518 mm/vmscan.c 4480 4481 static int isolate_folios(struct lruvec *lruvec, struct scan_control *sc, int swappiness, 4482 int *type_scanned, struct list_head *list) 4483 { 4484 int i; 4485 int type; 4486 int scanned; 4487 int tier = -1; 4488 bool unbalance; 4489 DEFINE_MIN_SEQ(lruvec); 4490 4491 /* 4492 * Try to make the obvious choice first. When anon and file are both 4493 * available from the same generation, interpret swappiness 1 as file 4494 * first and 200 as anon first. 4495 */ 4496 if (unlikely(unbalance_file_reclaim(sc, swappiness))) { 4497 unbalance = true; 4498 type = LRU_GEN_FILE; 4499 } else if (unlikely(unbalance_anon_reclaim(sc, swappiness))) { 4500 unbalance = true; 4501 type = LRU_GEN_ANON; 4502 } else if (!swappiness) 4503 type = LRU_GEN_FILE; 4504 else if (min_seq[LRU_GEN_ANON] < min_seq[LRU_GEN_FILE]) 4505 type = LRU_GEN_ANON; 4506 else if (swappiness == 1) 4507 type = LRU_GEN_FILE; 4508 else if (swappiness == 200) 4509 type = LRU_GEN_ANON; 4510 else 4511 type = get_type_to_scan(lruvec, swappiness, &tier); 4512 4513 for (i = !swappiness; i < ANON_AND_FILE; i++) { 4514 if (tier < 0) 4515 tier = get_tier_idx(lruvec, type); 4516 4517 scanned = scan_folios(lruvec, sc, type, tier, list); > 4518 if (scanned || unbalance) 4519 break; 4520 4521 type = !type; 4522 tier = -1; 4523 } 4524 4525 *type_scanned = type; 4526 4527 return scanned; 4528 } 4529 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki