[PATCH-cgroup] cgroup/cpuset: Optimize isolated partition only generate_sched_domains() calls

[PATCH-cgroup] cgroup/cpuset: Optimize isolated partition only generate_sched_domains() calls

[Waiman Long]

If only isolated partitions are being created underneath the cgroup root,
there will only be one sched domain with top_cpuset.effective_cpus. We can
skip the unnecessary sched domains scanning code and save some cycles.

Signed-off-by: Waiman Long <longman@redhat.com>
---
 kernel/cgroup/cpuset.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 315f8cbd6d35..f9b97f65e204 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -964,6 +964,7 @@ static int generate_sched_domains(cpumask_var_t **domains,
 
 	/* Special case for the 99% of systems with one, full, sched domain */
 	if (root_load_balance && !top_cpuset.nr_subparts) {
+single_root_domain:
 		ndoms = 1;
 		doms = alloc_sched_domains(ndoms);
 		if (!doms)
@@ -1022,6 +1023,13 @@ static int generate_sched_domains(cpumask_var_t **domains,
 	}
 	rcu_read_unlock();
 
+	/*
+	 * If there are only isolated partitions underneath the cgroup root,
+	 * we can optimize out unneeded sched domains scanning.
+	 */
+	if (root_load_balance && (csn == 1))
+		goto single_root_domain;
+
 	for (i = 0; i < csn; i++)
 		csa[i]->pn = i;
 	ndoms = csn;
-- 
2.39.3

Re: [PATCH-cgroup] cgroup/cpuset: Optimize isolated partition only generate_sched_domains() calls

[Tejun Heo]

On Mon, Jun 03, 2024 at 03:38:22PM -0400, Waiman Long wrote:
> If only isolated partitions are being created underneath the cgroup root,
> there will only be one sched domain with top_cpuset.effective_cpus. We can
> skip the unnecessary sched domains scanning code and save some cycles.
> 
> Signed-off-by: Waiman Long <longman@redhat.com>

Applied to cgroup/for-6.11.

Thanks.

-- 
tejun