Re: [PATCH v3 1/1] memcg/hugetlb: Adding hugeTLB counters to memcg

Joshua Hahn
2024-10-30T20:43:57Z

On Wed, Oct 30, 2024 at 2:30 PM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> Joshua, can you please include something like this at the end:
>
> lruvec_stat_mod_folio() keys off of folio->memcg linkage, which is
> only set up if CGRP_ROOT_MEMORY_HUGETLB_ACCOUNTING is switched
> on. This ensures that memory.stat::hugetlb is in sync with the hugetlb
> share of memory.current.

Hello Andrew,

I saw that it was merged into mm-unstable earlier yesterday. Would it
be possible
to add this block of text to the patch description right before the footnotes?

3. Implementation Details:
In the alloc / free hugetlb functions, we call lruvec_stat_mod_folio
regardless of whether memcg accounts hugetlb. lruvec_stat_mod_folio
keys off of folio->memcg which is only set up if the
CGRP_ROOT_MEMORY_HUGETLB_ACCOUTING cgroup mount option is used, so
it will not try to accumulate hugetlb unless the flag is set.
This also ensures that memory.stat::hugetlb is the same as
the share of memory.current that is used by hugetlb pages.

And could you also update the list of signatures to reflect the
responses on this version?
Suggested-by: Nhat Pham <nphamcs@gmail.com>
Suggested-by: Shakeel Butt <shakeel.butt@linux.dev>
Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Chris Down <chris@chrisdown.name>
Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
Reviewed-by: Nhat Pham <nphamcs@gmail.com>
Signed-off-by: Joshua Hahn <joshua.hahnjy@gmail.com>

Thank you so much, I hope you have a great rest of your day.
Joshua