From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
"Paul E. McKenney" <paulmck@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hillf Danton <hdanton@sina.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Marco Elver <elver@google.com>, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
tglx@linutronix.de
Subject: Re: [PATCH v2 1/2] kernfs: Make it possible to use RCU for kernfs_node::name lookup.
Date: Fri, 15 Nov 2024 18:32:56 +0100 [thread overview]
Message-ID: <20241115173256.13IVHFNn@linutronix.de> (raw)
In-Reply-To: <u7h5zfjxz7yo6e2ukrlnznj4ug66pgu2cel4jqejjji4lzphv7@2b4ntlfl7q2g>
On 2024-11-14 14:48:16 [+0100], Michal Koutný wrote:
> On Tue, Nov 12, 2024 at 04:52:38PM GMT, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> > --- a/include/linux/kernfs.h
> > +++ b/include/linux/kernfs.h
> > @@ -147,6 +147,11 @@ enum kernfs_root_flag {
> > * Support user xattrs to be written to nodes rooted at this root.
> > */
> > KERNFS_ROOT_SUPPORT_USER_XATTR = 0x0008,
> > +
> > + /*
> > + * Renames must not change the parent node.
> > + */
> > + KERNFS_ROOT_SAME_PARENT = 0x0010,
>
> FTR, cgroup v2 doesn't even define renames and the full rename
> (different parent) is only used by resctrl filesystem AFAICS.
> I'm only mentioning it in the case you wanted to replace the flag with
> two different rename methods in kernfs_syscall_ops.
Thanks. I think I have enough clues for a v3 now. I wanted to do
something today but didn't manage it yet.
> Thanks for fixing this locking situation in general,
> Michal
Sebastian
next prev parent reply other threads:[~2024-11-15 17:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 15:52 [PATCH v2 0/2] Let cgroup use RCU for kernfs_node::name lookup Sebastian Andrzej Siewior
2024-11-12 15:52 ` [PATCH v2 1/2] kernfs: Make it possible to " Sebastian Andrzej Siewior
2024-11-12 18:52 ` Tejun Heo
2024-11-13 7:42 ` Sebastian Andrzej Siewior
2024-11-14 13:48 ` Michal Koutný
2024-11-15 17:32 ` Sebastian Andrzej Siewior [this message]
2024-11-12 15:52 ` [PATCH v2 2/2] cgroup, kernfs: Move cgroup to the RCU interface for name lookups Sebastian Andrzej Siewior
2024-11-12 18:59 ` Tejun Heo
2024-11-13 7:43 ` Sebastian Andrzej Siewior
2024-11-13 12:07 ` Sebastian Andrzej Siewior
2024-11-13 13:23 ` Sebastian Andrzej Siewior
2024-11-13 18:28 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115173256.13IVHFNn@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=elver@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=paulmck@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox