From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C0A8266574 for ; Mon, 24 Feb 2025 16:56:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740416192; cv=none; b=cz7cBNERFNKHDYQduqAkThfPRdMfvxHyKFAgywD+Y4BJwf4UkRbCd6+7hQdL8NcNBtVhqHqou95htE7oN29k3RUbw948GGmRM19P/06h7s1vhIhYdXyLKZ59buyQ+UdurQCm9IhV2aYIKrsWnT4TcFiVqhMapY02qtkqml3ohMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740416192; c=relaxed/simple; bh=OBXpWDsR7o4dKf8NkhRON4PwL/H6iQiwplPc25GckEo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bsYTxZ+kVZ/wA1DhdE3QUmT1romVOCdr0hwb6MUmaIDn1CFdMNh5fukVrj4B8RUdEU5mUGK1pQOKEBJoQjdYzhjBkfFl5gfAy26PoHtLZO104HgZ1i0HI7iWGUPuY2NMSoOnz6Y8o0WASfSOaERVSZBJJBztcev5LSSwagG4dfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GXSIAcDw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GXSIAcDw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740416189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VusPlBbKEOGpL4wS1BqoWY6CYb2f4HQ+/wIDh8p+vAo=; b=GXSIAcDwufAWg0YwVWCfMZiIy83ilr2g1jbMeBNqunZoCZT1v8vMm9a900zGlqzaqjp7FU aUuB8pP8/FVzp9VoHHh6y6pgmArEiutiuD9MFakCNsJ/RVb/zKVIUEvDJc44C0/+MtwEs7 s82O6p+Usyu5W2foCj12MZ3EALznRcM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-Wzdxz8n0N4mHAM_KIQirEg-1; Mon, 24 Feb 2025 11:56:27 -0500 X-MC-Unique: Wzdxz8n0N4mHAM_KIQirEg-1 X-Mimecast-MFC-AGG-ID: Wzdxz8n0N4mHAM_KIQirEg_1740416186 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4393e873962so23628865e9.3 for ; Mon, 24 Feb 2025 08:56:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740416186; x=1741020986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VusPlBbKEOGpL4wS1BqoWY6CYb2f4HQ+/wIDh8p+vAo=; b=Um1FTK9vPdJ11zRHax9ojxp16t3B+4NtQVRbrx8F8y3mGQpH6K0gEJB4qvRVYATjXw H4QCXVG/NUbFoUiGHkIUfOX32zG7OJ2rXQFi1N0Y/Pea/v/xQBLRbimvGFiyv90KbzVG K2tW8/zGVvV852HkUwyLEiMeAg4msrG/RH20Wt3+hphdYq30LGu/RGfhkXDxOp6JuSB8 wLi5zwcjUOz+PU5fZGozKL8go3ZrmsDxZKRMpZDhMSYi6Qidj1ki37s96a/4or/gysuJ G7s0ZINI4E19HlL5actD9jXDNKuNooiBjbQASiitWE9wuTfh3YrXjx5gNTOn2UVojj7I Ummw== X-Forwarded-Encrypted: i=1; AJvYcCVOOere/Ddf0XXOAWRIuPDeaeWOfGEkF1mRZYyu0fcXSR82PT06K2xQ8dp3Ljbsf5HUU7Sp7S4B@vger.kernel.org X-Gm-Message-State: AOJu0Yz1fSf6sOYQHky3wuXB4pXz54oguMUJCxsJSKyGtL6pWQBCKTQE Zk0jOUEEOiZJ2r776nz9v5ZCQ9ruFH8qP34b1YxQNRUn5CC5mP7LxXUOrkQCabbgjggtkLZecds zgskq9fNNZpxZxhiOd/h8x84qgaU6kOPUaB5tOQgXOkvvQ93TAcj03i8= X-Gm-Gg: ASbGncsyzzydOp5Xaaj53jc5TDrUsQJwbEEnSaIXh350QvDKL6PLjdkNnP02bf6+uzM 1cO1OvPw+bO2JE/JXOaePkMOwBME2sDYFLyN9XBprSmIyKDobCEhbV5FZXFXttJTuFLaeNjsrXB E7prMawHmaf1us/nP4TcV4X0AzEmaLlEhIHPn6jhjBAvAeeqGXAcSLoDByk4U2cmYC/Sdk/szlu UpoZ/ZC0Tz62JjIiPNexu47Dj68Xb6NL91JCTgJreFpze52E2sCAL3Tihk/Ngn91ERSwzkS0yP2 2LmoxkvuZrYYKCC+XEb20T+w9J9Av/6GKH9dq6n2Wg== X-Received: by 2002:a05:600c:4f43:b0:439:9828:c425 with SMTP id 5b1f17b1804b1-43ab0f2db61mr336645e9.7.1740416186362; Mon, 24 Feb 2025 08:56:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IHWfaIC9jLsYbcLXi3Fdeg1qCi0/sJNUC8bLA+3qaJ5mWtkIjQvv3YtNjkQQj/btQBGxQxPlw== X-Received: by 2002:a05:600c:4f43:b0:439:9828:c425 with SMTP id 5b1f17b1804b1-43ab0f2db61mr336445e9.7.1740416185910; Mon, 24 Feb 2025 08:56:25 -0800 (PST) Received: from localhost (p4ff234b6.dip0.t-ipconnect.de. [79.242.52.182]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-439b030b347sm111391345e9.26.2025.02.24.08.56.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 08:56:25 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, David Hildenbrand , Andrew Morton , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Jonathan Corbet , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Muchun Song , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn Subject: [PATCH v2 10/20] bit_spinlock: __always_inline (un)lock functions Date: Mon, 24 Feb 2025 17:55:52 +0100 Message-ID: <20250224165603.1434404-11-david@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250224165603.1434404-1-david@redhat.com> References: <20250224165603.1434404-1-david@redhat.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The compiler might decide that it is a smart idea to not inline bit_spin_lock(), primarily when a couple of functions in the same file end up calling it. Especially when used in RMAP map/unmap code next, the compiler sometimes decides to not inline, which is then observable in some micro-benchmarks. Let's simply flag all lock/unlock functions as __always_inline; arch_test_and_set_bit_lock() and friends are already tagged like that (but not test_and_set_bit_lock() for some reason). If ever a problem, we could split it into a fast and a slow path, and only force the fast path to be inlined. But there is nothing particularly "big" here. Signed-off-by: David Hildenbrand --- include/linux/bit_spinlock.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/bit_spinlock.h b/include/linux/bit_spinlock.h index bbc4730a6505c..c0989b5b0407f 100644 --- a/include/linux/bit_spinlock.h +++ b/include/linux/bit_spinlock.h @@ -13,7 +13,7 @@ * Don't use this unless you really need to: spin_lock() and spin_unlock() * are significantly faster. */ -static inline void bit_spin_lock(int bitnum, unsigned long *addr) +static __always_inline void bit_spin_lock(int bitnum, unsigned long *addr) { /* * Assuming the lock is uncontended, this never enters @@ -38,7 +38,7 @@ static inline void bit_spin_lock(int bitnum, unsigned long *addr) /* * Return true if it was acquired */ -static inline int bit_spin_trylock(int bitnum, unsigned long *addr) +static __always_inline int bit_spin_trylock(int bitnum, unsigned long *addr) { preempt_disable(); #if defined(CONFIG_SMP) || defined(CONFIG_DEBUG_SPINLOCK) @@ -54,7 +54,7 @@ static inline int bit_spin_trylock(int bitnum, unsigned long *addr) /* * bit-based spin_unlock() */ -static inline void bit_spin_unlock(int bitnum, unsigned long *addr) +static __always_inline void bit_spin_unlock(int bitnum, unsigned long *addr) { #ifdef CONFIG_DEBUG_SPINLOCK BUG_ON(!test_bit(bitnum, addr)); @@ -71,7 +71,7 @@ static inline void bit_spin_unlock(int bitnum, unsigned long *addr) * non-atomic version, which can be used eg. if the bit lock itself is * protecting the rest of the flags in the word. */ -static inline void __bit_spin_unlock(int bitnum, unsigned long *addr) +static __always_inline void __bit_spin_unlock(int bitnum, unsigned long *addr) { #ifdef CONFIG_DEBUG_SPINLOCK BUG_ON(!test_bit(bitnum, addr)); -- 2.48.1