From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 475D8263F54 for ; Mon, 24 Feb 2025 16:56:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740416172; cv=none; b=rgdON/jfpp7e1Zqqg2jGotLTkzTUR1MuEWwxX1pQsVSRzvEWoBxW2D5MZJbIYwzUArqdbLvDXj2Xu7qvv5x0XEI/Zr4LWmlVzh8YO7tk+GkXZggDRQI3GWYLT+7JfqR4FiP62k2zTnjxOtCjKQczsBsDnsE6v+UziuWyw4tjTsQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740416172; c=relaxed/simple; bh=VmpdZSRRUc/hbRQ4rkKLLuRh8r6J0srT0ICzqEnE21Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ah9xdTstY6B8N14kw2gSlx5yCoQWkgiCO8kd5Tbdut9zjFe8Qby6mTe/xDg4V9Is1YYC5X64PAAAOTRPe2I8QBw1WpCVYVb47UrJo4L+Rmv4OroKZI8QT71QFKGINecdWGpKVsLt2dBeO7xmFAMyqzq1FdrYgrx6/m6agm2oKmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jT2VXVDV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jT2VXVDV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740416170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Yy4w/XZlsv8uxY4mojETBma8CfgELpSYNnd4DKCaPQ=; b=jT2VXVDVNp0WrvCETXgM47QZ8N1JeIqSkNhFs1CkuqmWLzLZNbx4GtMVK0YECYI2je3ehX Hc1QfgzcnLU4Hf6VI2PxzPQwu0lq2kzDfrModrcnBa+6J6E2kmJ993/+G4FUyErGLA+gsM FhbGjMHYwC9oobmcIga1KWlDUzm38yc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-hElim11CO1mngvZ2XR8ljg-1; Mon, 24 Feb 2025 11:56:08 -0500 X-MC-Unique: hElim11CO1mngvZ2XR8ljg-1 X-Mimecast-MFC-AGG-ID: hElim11CO1mngvZ2XR8ljg_1740416168 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4399a5afcb3so40210875e9.3 for ; Mon, 24 Feb 2025 08:56:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740416167; x=1741020967; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Yy4w/XZlsv8uxY4mojETBma8CfgELpSYNnd4DKCaPQ=; b=jutWyAV+GhHV0trAjxeblzESpvZZVUpbGmcCNnmyxhTsmK5AwEkoFLVRjxkjRbTpOT XvrOUEgZrePZ80oBIZvD89cex38BNFs5JVDOWN/B7ejFybceY/xTU2uvzVFYZgZE4LZA 9ztC5ntmmP/wrqvYN0I3pgC68GUQfnjTlkgfsy+aJ13NVoEwd2QpJX9fPNcV4DqrgERT VYdR3g8RwJ+ZDaOXe36mOBLdnCBvHFjiLNi6MQXYMoYnH/WAXOtYUvHeJ801ykmTvA3M wCoqHG0wAoOWeK5sGyp1egANzwvfGL8RUZq8cy9xPqetuJVzF5oLrohHeWLRdD3ixbiM fIOg== X-Forwarded-Encrypted: i=1; AJvYcCU55Y3GprdvwiI2w3GMtDWpLtyF2NH+qISVejpmTMzUTzDv/W6YBvLXWqCJbEStviBqcxqIYe74@vger.kernel.org X-Gm-Message-State: AOJu0YydVspypQiQxHSV3BMbUYoUbvakGvDxNzNs8ybwSejMFwOyZQc8 ABIXPriraHX45I/XPablwQfYDt2ctguDPgRXOCAlsWvcvYAlmwJR8W39O0XezO7KZRoBX0wJS1J IwJjpZDCeEUfxbzRIXLB4oALCnxHbjyOQAjtBmdmTp+KMPWZ1RFnYlzM= X-Gm-Gg: ASbGncs9AioMmZSmXWoISnTCmjhGeZVftWH9pwoYQ7tgQ5KWsZDRSNG5HDPNeoGdsvb ueLofLDhP5TZGtz26oqRfkc//EZcM0gu2Zd+IPdxWMvP24+LWirZ+fBQVhjchWX6yYAGPfe1qov JKgnJkxD2WcUNdw7nNYZ65QZoGo34csFQIHzKTJ9Fstz7OgMjC773r9tiEGpGug8Vi7uDqNy7++ gFS+ZVmQjSePDLpQ2gKiuA81HWsM7hAyGHBPX1yXNYSuW981BkID2NJBjMR7FPltOQXiWaB2mCS Xj7jo58c1pkvC2qxsEHZYfREeeNm0iGVZvhDhKlqtg== X-Received: by 2002:a05:6000:1ac7:b0:38f:2a99:b377 with SMTP id ffacd0b85a97d-38f6f0c4523mr13709706f8f.53.1740416167619; Mon, 24 Feb 2025 08:56:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrYsCtuTnI9EW4wn4ZrbygGJqAwQI73Wf+OvRO5jakiYr702W8tJwU3BfJXILKECpWzIC3lQ== X-Received: by 2002:a05:6000:1ac7:b0:38f:2a99:b377 with SMTP id ffacd0b85a97d-38f6f0c4523mr13709656f8f.53.1740416167205; Mon, 24 Feb 2025 08:56:07 -0800 (PST) Received: from localhost (p4ff234b6.dip0.t-ipconnect.de. [79.242.52.182]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-38f259d5e92sm32611493f8f.66.2025.02.24.08.56.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 08:56:06 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, David Hildenbrand , Andrew Morton , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Jonathan Corbet , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Muchun Song , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Lance Yang , "Kirill A. Shutemov" Subject: [PATCH v2 01/20] mm: factor out large folio handling from folio_order() into folio_large_order() Date: Mon, 24 Feb 2025 17:55:43 +0100 Message-ID: <20250224165603.1434404-2-david@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250224165603.1434404-1-david@redhat.com> References: <20250224165603.1434404-1-david@redhat.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Let's factor it out into a simple helper function. This helper will also come in handy when working with code where we know that our folio is large. Maybe in the future we'll have the order readily available for small and large folios; in that case, folio_large_order() would simply translate to folio_order(). Reviewed-by: Lance Yang Reviewed-by: Kirill A. Shutemov Signed-off-by: David Hildenbrand --- include/linux/mm.h | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index d82feabbe44f8..d00214e22a174 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1194,6 +1194,11 @@ struct inode; extern void prep_compound_page(struct page *page, unsigned int order); +static inline unsigned int folio_large_order(const struct folio *folio) +{ + return folio->_flags_1 & 0xff; +} + /* * compound_order() can be called without holding a reference, which means * that niceties like page_folio() don't work. These callers should be @@ -1207,7 +1212,7 @@ static inline unsigned int compound_order(struct page *page) if (!test_bit(PG_head, &folio->flags)) return 0; - return folio->_flags_1 & 0xff; + return folio_large_order(folio); } /** @@ -1223,7 +1228,7 @@ static inline unsigned int folio_order(const struct folio *folio) { if (!folio_test_large(folio)) return 0; - return folio->_flags_1 & 0xff; + return folio_large_order(folio); } #include @@ -2139,7 +2144,7 @@ static inline long folio_nr_pages(const struct folio *folio) #ifdef CONFIG_64BIT return folio->_folio_nr_pages; #else - return 1L << (folio->_flags_1 & 0xff); + return 1L << folio_large_order(folio); #endif } @@ -2164,7 +2169,7 @@ static inline unsigned long compound_nr(struct page *page) #ifdef CONFIG_64BIT return folio->_folio_nr_pages; #else - return 1L << (folio->_flags_1 & 0xff); + return 1L << folio_large_order(folio); #endif } -- 2.48.1