cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xin Zhao <jackzxcui1989@163.com>
To: tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com,
	mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	vschneid@redhat.com, will@kernel.org, boqun.feng@gmail.com,
	longman@redhat.com, bigeasy@linutronix.de, clrkwllms@kernel.org
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH] sched/cgroup: Lock optimize for cgroup cpu throttle
Date: Tue, 12 Aug 2025 00:04:54 +0800	[thread overview]
Message-ID: <20250811160454.884224-1-jackzxcui1989@163.com> (raw)

On Mon, 2025-08-11 at 22:18 +0800, Sebastian wrote:

> Yeah, please have a look at:
> https://lore.kernel.org/lkml/20250715071658.267-1-ziqianlu@bytedance.com/


Dear Valentin,

In addition to the information in my previous response to Sebastian, I would
like to add the following point as a reason for my self-recommendation (to
explore my patch for solving the cgroup performance issue in RT-Linux):
RT-Linux is a system that places a high emphasis on real-time performance.
The fact that regular tasks are also included in cgroup groups and throttled
suggests that they are relatively low-priority tasks that are not expected to
interfere with high-priority tasks. Therefore, is it not a bit too late to
impose limits only after returning to user mode? Furthermore, when a throttled
task is awakened from S or D state, according to the logic of "imposing limits
after returning to user mode," it could cause that low-priority task to wake
up associated low-priority tasks one after another, leading to a sudden
increase in running time, which contradicts the relatively precise CPU usage
targets typically required in RT-Linux systems.
Additionally, I believe there are still many areas for improvement in my patch,
and I hope to bring it to the community to gather suggestions from experts to
see if there are areas for iterative improvement.


Thanks
Xin Zhao


             reply	other threads:[~2025-08-11 16:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11 16:04 Xin Zhao [this message]
2025-08-19 11:28 ` [PATCH] sched/cgroup: Lock optimize for cgroup cpu throttle Valentin Schneider
  -- strict thread matches above, loose matches on Subject: below --
2025-08-20  8:04 Xin Zhao
2025-08-11 15:13 Xin Zhao
2025-08-19 13:06 ` Sebastian Andrzej Siewior
2025-08-11  7:08 Xin Zhao
2025-08-11  8:36 ` Sebastian Andrzej Siewior
2025-08-11 14:18   ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250811160454.884224-1-jackzxcui1989@163.com \
    --to=jackzxcui1989@163.com \
    --cc=bigeasy@linutronix.de \
    --cc=boqun.feng@gmail.com \
    --cc=bsegall@google.com \
    --cc=cgroups@vger.kernel.org \
    --cc=clrkwllms@kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=longman@redhat.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).