From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F6F22DF712 for ; Tue, 16 Sep 2025 04:48:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998131; cv=none; b=tDnCis/7YGLrqD52OQWpuDO8btlc/hD3IytVG6cLiPU/43BvjVg9DBL9jytV4CF6GD0tTxpi3Rfe9kWlCFmCuIiwd/kQGQoPgfItmtvjNZC0rACL4XLk6dA/sSld8Sr0Aa7esJZ/OnSteIuvcjJonshSnYQ7GhtjX4JDpSqi8Bg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998131; c=relaxed/simple; bh=McKpF5pbp0B08HxMwaOQh+77moGljXjpv9ExEqMvqrY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=O1ammFMUDD0QykLRGNYHdtMkS4rAOW3dlFaaEgCUpHQrhOtoDKGxQO93oF3R556O4+84cZS6NNzihZjaNRJyodgzbf4v/ubay0sL3Ho2nXXYifUkXzcs7XHzjDCBYhtyzcvT0iM9Wb+qdkAtikNc1AiYoyGmQL6Njl4G1TIebnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iAsxqDJG; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iAsxqDJG" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-b4c9a6d3fc7so3047815a12.3 for ; Mon, 15 Sep 2025 21:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757998127; x=1758602927; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KdSOTRlpcbSm77LoC5qTO7Qj2WXZD3913QNmAyohauk=; b=iAsxqDJGyK6tvzTorEsVSUEuBJHI7lzp/5BEV9Wux96nvmddvYxeJQ1Pxvpd2zxtF/ odfGJC6i+MsiMQaqOK2xq8ZI0ARkBidTF5I5eqq1ZR8Qjn+DauG6LysiVeyKRFvX28EL w6ZcpLJnXs6zocIW71x6zkcJ5+FAND5iyun6X1dBQ46MVXBvupNiU+xnLnPuRzi43J08 BA1c5fGxCyMnm79SP3kRQxMi+O6QScp7FJQkKJCIjiivp3mQfwQ1xz1JjfoSzAPM7acG j6yJZpPiCXYc7n4vedVIAlccqhiIo5yA+omWiEO/NiWZlviC3u17B0o+jpKhtDTDqd64 n6Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757998127; x=1758602927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KdSOTRlpcbSm77LoC5qTO7Qj2WXZD3913QNmAyohauk=; b=MsBXHQXnhnk2TnKCF3BOrA2RBh1dAIAsSeR310Bf7ZRtVoyhywrB53qaQS6r9iLAy+ t2/tHIKecmXazJLiN99nnBmjAICG6Tv9IXXsEOsL43wJdYByO+4x1d68BHTZNCEiv500 58XV1kp7uN8z+/49i4f2oUtmynbwNGjAGbnss7HnMxRXjmzEFDsHMVK4PP1XfBtVWA+f Fhd58zgIS5RO4h34SLBVgS9hoLL1ig73vygkV9f+Y2A4yHTjcuB7K61cG/9xyNObjmAG PEOghQlvcLqb1KGIqoecoCzGQuDOyujKp/krf+oYtqLkqXsdaNm4FWzHg83RyTjrSUYz yV9A== X-Forwarded-Encrypted: i=1; AJvYcCWdEbJiEKWZ6fwb1Wt/C7KLqEhfvpOYkhcUbzX3V6cFdt+GqFJ74afp699qtDCskqLfqynTJs6n@vger.kernel.org X-Gm-Message-State: AOJu0Yxy8/R/Geskg28tJlnkL2S9VOcVEr9KsTKf+o5iA/w+1exBbK1f M7+9Dv67/B0IooE24lKBaZdajwOVGSR84YzGQ7sQlTcyVW3fDy9yLdVj X-Gm-Gg: ASbGncv0s8V236z1+Aw/SCkqogCicq+SL/EsJ3aCfjZFEJ0jp/Sn6ebGtwRe9HMU6z8 jek3g9rdlrW4vbvOtzzVzSNMjH2Re51AoCPf6aqAubkuYma0FdDv07kYJk/gM9iIIvNyX8l6mxu w0EyB9kl6vprXMmuGwmcXH0Eda0h3NR4AAEEATtxfXcd0fgZUa87qz/mBQeFWxVG9TmHJgpj0W0 tbbFrfvT3dYzan6XzG/NAWZ8Be9G/7DVLesTM9zGk8BbhXMsluZuEQRzjh1KqagaxR0vj4xpeqD h3zIUia/nTUe63dWyVmjQ5wP98gc4PTMCvbAeS5Sb4wIXN82Ym+cBDcYSiD16er5apTbsv/Rk+k Ivly5x4AtiBgRube5ex47+papVODNRR20JQiiUdU= X-Google-Smtp-Source: AGHT+IGkIhcIMGh+oiZ/aDBZPsHwPAhQG69OhML0E/f2mr/YjQA5clLbS6Ua4uwzILjLJIA06eQ5gQ== X-Received: by 2002:a17:902:d2c4:b0:25e:5d83:2ddd with SMTP id d9443c01a7336-25e5d832fdcmr159755585ad.45.1757998127447; Mon, 15 Sep 2025 21:48:47 -0700 (PDT) Received: from pengdl-pc.mioffice.cn ([43.224.245.249]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25ef09c77f8sm104600605ad.15.2025.09.15.21.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 21:48:46 -0700 (PDT) From: pengdonglin To: tj@kernel.org, tony.luck@intel.com, jani.nikula@linux.intel.com, ap420073@gmail.com, jv@jvosburgh.net, freude@linux.ibm.com, bcrl@kvack.org, trondmy@kernel.org, longman@redhat.com, kees@kernel.org Cc: bigeasy@linutronix.de, hdanton@sina.com, paulmck@kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-nfs@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-wireless@vger.kernel.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, cgroups@vger.kernel.org, pengdonglin , Holger Dengler , Vasily Gorbik , Alexander Gordeev , pengdonglin Subject: [PATCH v3 05/14] s390/pkey: Remove redundant rcu_read_lock/unlock() in spin_lock Date: Tue, 16 Sep 2025 12:47:26 +0800 Message-Id: <20250916044735.2316171-6-dolinux.peng@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250916044735.2316171-1-dolinux.peng@gmail.com> References: <20250916044735.2316171-1-dolinux.peng@gmail.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: pengdonglin Since commit a8bb74acd8efe ("rcu: Consolidate RCU-sched update-side function definitions") there is no difference between rcu_read_lock(), rcu_read_lock_bh() and rcu_read_lock_sched() in terms of RCU read section and the relevant grace period. That means that spin_lock(), which implies rcu_read_lock_sched(), also implies rcu_read_lock(). There is no need no explicitly start a RCU read section if one has already been started implicitly by spin_lock(). Simplify the code and remove the inner rcu_read_lock() invocation. Cc: Harald Freudenberger Cc: Holger Dengler Cc: Vasily Gorbik Cc: Alexander Gordeev Signed-off-by: pengdonglin Signed-off-by: pengdonglin --- drivers/s390/crypto/pkey_base.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/s390/crypto/pkey_base.c b/drivers/s390/crypto/pkey_base.c index b15741461a63..4c4a9feecccc 100644 --- a/drivers/s390/crypto/pkey_base.c +++ b/drivers/s390/crypto/pkey_base.c @@ -48,16 +48,13 @@ int pkey_handler_register(struct pkey_handler *handler) spin_lock(&handler_list_write_lock); - rcu_read_lock(); list_for_each_entry_rcu(h, &handler_list, list) { if (h == handler) { - rcu_read_unlock(); spin_unlock(&handler_list_write_lock); module_put(handler->module); return -EEXIST; } } - rcu_read_unlock(); list_add_rcu(&handler->list, &handler_list); spin_unlock(&handler_list_write_lock); -- 2.34.1