From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7401E2E427B for ; Tue, 16 Sep 2025 04:49:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998144; cv=none; b=Jb+Z4Cv4/xHKGRAFd2mqngJHj+w8pENtUJN/Yy/URi61jygHX/RYGYdt4ATevrHFFZdwICq3DJ9vhU2YcqJDOmzHVd+mo1PAK24DZvlNsRWSh7wNrsnsGVlMdKD9FVevHAf54+NlTtAaL6INYz7UNl7mNcWkcepVnOaITZECdNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998144; c=relaxed/simple; bh=HguuC3cJW9LHrBXuF3iFTqdhADSKZ6I2ZWC/adsG6L4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CrdE+N+ZGUNQS024m2C0LxGrebtogghyP/AyBpCZXhBpfjyxWE3PXGzObRl5Z7WaKxElwcXbYe3MKPNb4Z/oPih27LKNjxsYtcmG9xNX8Fvj+yM9VJohS1QTsQO0sCE3NMtk3GkNfqTdZECjpsMjXi8uRTe1+UXkhevV4xFvd5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SCefdEHH; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SCefdEHH" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-244580523a0so50862775ad.1 for ; Mon, 15 Sep 2025 21:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757998141; x=1758602941; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y26N2MyOP2FIPMMMBT4JTn6kc4P01rdpdKyvYPEfOYc=; b=SCefdEHHiZ8jZW6xYxJti7tA2y6Bt/GimNvdDYVlgmt2cdNVo7OAJcSr5LXKXEOZbf UGGGRX1bIlzd25p9XFG3/AuL4AFo52i36GuOp66KC85Uy/XbHwdetBCk4RfB+CQtV8gG bGB3fSsvylkjw0Qw4Syn2pjMO2oaoTpIVOMeW4ync7cEGsK5I0d5n9YApMb74KRv+vYB BDsg0UVn1UNIr5Bvs8KUVv/ud5TILGiBsHgcv/yWZ1/CxUmiVCACSIprr/HVidhnRt5o 0KUolDW/QN7el5Pxc8O7RQcX/fWH9lLT4zQlNsvIDmOvD+BeCZn4n36z8iFAwSLI9O/A kioQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757998141; x=1758602941; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y26N2MyOP2FIPMMMBT4JTn6kc4P01rdpdKyvYPEfOYc=; b=kKVxFOOl5cOa6TX2nk2nLG+rbf/Ksk382PPoWbJj+7hj1n3Dh8ypdK/Z5OXnviLsEA iQn2I7v0UYeOjDxsybOjNfBqOVS0ZCKw4oUQpQHWzESnLwZNx2YybmGR7YYlbSU9AZ7O aVrb3UR1BF5wsoLGvd1qSZ/ccYtbQq+NWDq9rzxaNwGVD0/hDWcxji2b0q4sIiqE1+0n K8gY4wwfJebx/of5Snb+pN4EVX7VU0JPpYSDA7L5oae+MJ/Nv4NwvB6S2wBlZJvU7Y6W O4XTZx3yjGE6ESDuEwsxM5KYNxk/uPSQn3Pk5XquyIVFv6rzT7jBy1by/OwxMNvBZ93x 8Lbg== X-Forwarded-Encrypted: i=1; AJvYcCUSWCdxqpe/gAz8IBpcpGCXOXmzysWKlwRPmFV7aCPJmAwL+TwX6ay5aqDyeKdhhyws8hMCmfJD@vger.kernel.org X-Gm-Message-State: AOJu0YzNWMf6JZb2i7cAcJx1WUsTmOVg+qbUkG2OUAuJSpC8Elusjvag iqfIS/6vxzCJ8tbe0cMm/C3hi66FLYsreH/6Pm6/DX6Ub1BaT3agNH6E X-Gm-Gg: ASbGnctqihxYafZSIScgBHePKsN7Ql5DIR7OTzbvX9h5p5adZ2WRtS9xMftaqOwc/P4 2HQNaltN5I97HczWFLR8xmF4NEkCCQDtqaV0V2WtTxU8lkKEE0A37EApMSNPzg7+gb61eGIUCRP bcVDam8eEL12PD1tDoTrSBCWphYPb6SkGl41vZ9iEbvZrM5TNhpPtW9sucxAd4wSK2XF3V2wIP7 W3DY1BS1KkAK0ZzesZexxxYk4XLmNcYKH2dEkT3QBIn2+DL2YF3jiBn9q+7Ocp02SDVgdUSh9l1 SVaGmlxpGu75ghdxdeUVbLmFdHktmKQQDJNkXpDyV5bVsVnBqIxy7jM0Kpvvy/NORalFRHd+EhL mp4qpxBoHEEiCERrqiGbooD2aTwt9qGGnpkUrUvM= X-Google-Smtp-Source: AGHT+IEF8hyGYSwfpfRfNi45Ml5S5Z1xWLwd/+S+vouYcjrRAMMRr1JH2N5TAK8bBOVvYAZpMt3b8w== X-Received: by 2002:a17:903:ac3:b0:267:d772:f845 with SMTP id d9443c01a7336-267d772fcf1mr8896415ad.52.1757998140582; Mon, 15 Sep 2025 21:49:00 -0700 (PDT) Received: from pengdl-pc.mioffice.cn ([43.224.245.249]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25ef09c77f8sm104600605ad.15.2025.09.15.21.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 21:49:00 -0700 (PDT) From: pengdonglin To: tj@kernel.org, tony.luck@intel.com, jani.nikula@linux.intel.com, ap420073@gmail.com, jv@jvosburgh.net, freude@linux.ibm.com, bcrl@kvack.org, trondmy@kernel.org, longman@redhat.com, kees@kernel.org Cc: bigeasy@linutronix.de, hdanton@sina.com, paulmck@kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-nfs@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-wireless@vger.kernel.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, cgroups@vger.kernel.org, pengdonglin , Paul Moore , James Morris , pengdonglin Subject: [PATCH v3 07/14] yama: Remove redundant rcu_read_lock/unlock() in spin_lock Date: Tue, 16 Sep 2025 12:47:28 +0800 Message-Id: <20250916044735.2316171-8-dolinux.peng@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250916044735.2316171-1-dolinux.peng@gmail.com> References: <20250916044735.2316171-1-dolinux.peng@gmail.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: pengdonglin Since commit a8bb74acd8efe ("rcu: Consolidate RCU-sched update-side function definitions") there is no difference between rcu_read_lock(), rcu_read_lock_bh() and rcu_read_lock_sched() in terms of RCU read section and the relevant grace period. That means that spin_lock(), which implies rcu_read_lock_sched(), also implies rcu_read_lock(). There is no need no explicitly start a RCU read section if one has already been started implicitly by spin_lock(). Simplify the code and remove the inner rcu_read_lock() invocation. Cc: Kees Cook Cc: Paul Moore Cc: James Morris Signed-off-by: pengdonglin Signed-off-by: pengdonglin --- security/yama/yama_lsm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c index 3d064dd4e03f..60d38deb181b 100644 --- a/security/yama/yama_lsm.c +++ b/security/yama/yama_lsm.c @@ -117,14 +117,12 @@ static void yama_relation_cleanup(struct work_struct *work) struct ptrace_relation *relation; spin_lock(&ptracer_relations_lock); - rcu_read_lock(); list_for_each_entry_rcu(relation, &ptracer_relations, node) { if (relation->invalid) { list_del_rcu(&relation->node); kfree_rcu(relation, rcu); } } - rcu_read_unlock(); spin_unlock(&ptracer_relations_lock); } @@ -152,7 +150,6 @@ static int yama_ptracer_add(struct task_struct *tracer, added->invalid = false; spin_lock(&ptracer_relations_lock); - rcu_read_lock(); list_for_each_entry_rcu(relation, &ptracer_relations, node) { if (relation->invalid) continue; @@ -166,7 +163,6 @@ static int yama_ptracer_add(struct task_struct *tracer, list_add_rcu(&added->node, &ptracer_relations); out: - rcu_read_unlock(); spin_unlock(&ptracer_relations_lock); return 0; } -- 2.34.1