From: Julian Sun <sunjunchao@bytedance.com>
To: cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, akpm@linux-foundation.org,
lance.yang@linux.dev, mhiramat@kernel.org, agruenba@redhat.com,
hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev,
shakeel.butt@linux.dev, muchun.song@linux.dev
Subject: [PATCH 2/3] writeback: Introduce wb_wait_for_completion_no_hung().
Date: Mon, 22 Sep 2025 17:41:45 +0800 [thread overview]
Message-ID: <20250922094146.708272-3-sunjunchao@bytedance.com> (raw)
In-Reply-To: <20250922094146.708272-1-sunjunchao@bytedance.com>
This patch introduces wait_event_no_hung() and
wb_wait_for_completion_no_hung() to make hung task detector
ignore the current task if it waits for a long time.
Signed-off-by: Julian Sun <sunjunchao@bytedance.com>
---
fs/fs-writeback.c | 15 +++++++++++++++
include/linux/backing-dev.h | 1 +
include/linux/wait.h | 15 +++++++++++++++
3 files changed, 31 insertions(+)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index a07b8cf73ae2..eebb7f145734 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -216,6 +216,21 @@ void wb_wait_for_completion(struct wb_completion *done)
wait_event(*done->waitq, !atomic_read(&done->cnt));
}
+/*
+ * Same as wb_wait_for_completion() but hung task warning will not be
+ * triggered if it wait for a long time. Use this function with caution
+ * unless you are sure that the hung task is undesirable.
+ * When is this undesirable? From the kernel code perspective, there is
+ * no misbehavior and it has no impact on user behavior. For example, a
+ * *background* kthread/kworker used to clean resources while waiting a
+ * long time for writeback to finish.
+ */
+ void wb_wait_for_completion_no_hung(struct wb_completion *done)
+ {
+ atomic_dec(&done->cnt); /* put down the initial count */
+ wait_event_no_hung(*done->waitq, !atomic_read(&done->cnt));
+ }
+
#ifdef CONFIG_CGROUP_WRITEBACK
/*
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index e721148c95d0..9d3335866f6f 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -40,6 +40,7 @@ void wb_start_background_writeback(struct bdi_writeback *wb);
void wb_workfn(struct work_struct *work);
void wb_wait_for_completion(struct wb_completion *done);
+void wb_wait_for_completion_no_hung(struct wb_completion *done);
extern spinlock_t bdi_lock;
extern struct list_head bdi_list;
diff --git a/include/linux/wait.h b/include/linux/wait.h
index 09855d819418..8f05d0bb8db7 100644
--- a/include/linux/wait.h
+++ b/include/linux/wait.h
@@ -330,6 +330,21 @@ __out: __ret; \
(void)___wait_event(wq_head, condition, TASK_UNINTERRUPTIBLE, 0, 0, \
schedule())
+#define __wait_event_no_hung(wq_head, condition) \
+ (void)___wait_event(wq_head, condition, TASK_UNINTERRUPTIBLE, 0, 0, \
+ current_set_flags(PF_DONT_HUNG); \
+ schedule(); \
+ current_clear_flags(PF_DONT_HUNG))
+
+#define wait_event_no_hung(wq_head, condition) \
+do { \
+ might_sleep(); \
+ if (condition) \
+ break; \
+ __wait_event_no_hung(wq_head, condition); \
+} while (0)
+
+
/**
* wait_event - sleep until a condition gets true
* @wq_head: the waitqueue to wait on
--
2.39.5
next prev parent reply other threads:[~2025-09-22 9:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 9:41 [PATCH 0/3] Suppress undesirable hung task warnings Julian Sun
2025-09-22 9:41 ` [PATCH 1/3] sched: Introduce a new flag PF_DONT_HUNG Julian Sun
2025-09-22 9:41 ` Julian Sun [this message]
2025-09-22 9:41 ` [PATCH 3/3] memcg: Don't trigger hung task warnings when memcg is releasing resources Julian Sun
2025-09-22 11:38 ` [PATCH 0/3] Suppress undesirable hung task warnings Lance Yang
2025-09-22 12:40 ` Julian Sun
2025-09-22 13:12 ` Lance Yang
2025-09-22 21:57 ` Andrew Morton
2025-09-23 2:30 ` Lance Yang
2025-09-23 2:45 ` [External] " Julian Sun
2025-09-23 3:18 ` Lance Yang
2025-09-22 13:07 ` Michal Hocko
2025-09-22 14:24 ` [External] " Julian Sun
2025-09-22 13:27 ` Peter Zijlstra
2025-09-22 14:29 ` [External] " Julian Sun
2025-09-22 15:27 ` Jan Kara
2025-09-22 18:08 ` Christoph Hellwig
2025-09-22 21:50 ` Andrew Morton
2025-09-23 7:16 ` Peter Zijlstra
2025-09-23 12:44 ` Masami Hiramatsu
2025-09-24 10:34 ` Jan Kara
2025-09-25 15:07 ` [External] " Julian Sun
2025-09-25 16:30 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922094146.708272-3-sunjunchao@bytedance.com \
--to=sunjunchao@bytedance.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=bsegall@google.com \
--cc=cgroups@vger.kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=juri.lelli@redhat.com \
--cc=lance.yang@linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mhiramat@kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=muchun.song@linux.dev \
--cc=peterz@infradead.org \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=shakeel.butt@linux.dev \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox